kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add test for simple ciricular dependency in extends

Browse source
This commit is contained in:
Grzegorz Bizon 2018-08-16 15:33:24 +02:00
parent 2c41fbb148
commit 2f05e34b3c
1 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
spec/lib/gitlab/ci/config/extendable/collection_spec.rb
View file

@ -116,8 +116,7 @@ describe Gitlab::Ci::Config::Extendable::Collection do
end
end
pending 'when invalid `extends` is specified'
context 'when circular dependecy has been detected' do
context 'when nested circular dependecy has been detected' do
let(:hash) do
{
test: {
@ -145,5 +144,24 @@ describe Gitlab::Ci::Config::Extendable::Collection do
.to raise_error(described_class::CircularDependencyError)
end
end
context 'when circular dependecy to self has been detected' do
let(:hash) do
{
test: {
extends: 'test',
script: 'ls',
only: { refs: %w[master] }
}
}
end
it 'raises an error' do
expect { subject.extend! }
.to raise_error(described_class::CircularDependencyError)
end
end
pending 'when invalid `extends` is specified'
end
end