From 2f0ec5c01761033edbadc1f450e4f414f86cc2d9 Mon Sep 17 00:00:00 2001
From: Enrique Alcantara <ealcantara@gitlab.com>
Date: Wed, 29 May 2019 18:42:07 -0400
Subject: [PATCH] Add updateSuccessful/Failed props to knative app

They are used to indicate when knative domain name
has changed
---
 .../clusters/components/application_row.vue   | 60 ++++++++++---------
 .../clusters/stores/clusters_store.js         |  2 +
 .../clusters/stores/clusters_store_spec.js    |  2 +
 3 files changed, 37 insertions(+), 27 deletions(-)

diff --git a/app/assets/javascripts/clusters/components/application_row.vue b/app/assets/javascripts/clusters/components/application_row.vue
index 5f7675bb432..eb92a4dd980 100644
--- a/app/assets/javascripts/clusters/components/application_row.vue
+++ b/app/assets/javascripts/clusters/components/application_row.vue
@@ -89,6 +89,10 @@ export default {
       type: Boolean,
       required: false,
     },
+    updateable: {
+      type: Boolean,
+      default: true,
+    },
     updateSuccessful: {
       type: Boolean,
       required: false,
@@ -326,36 +330,38 @@ export default {
           </ul>
         </div>
 
-        <div
-          v-if="shouldShowUpgradeDetails"
-          class="form-text text-muted label p-0 js-cluster-application-upgrade-details"
-        >
-          {{ versionLabel }}
-          <span v-if="updateSuccessful">to</span>
-
-          <gl-link
-            v-if="updateSuccessful"
-            :href="chartRepo"
-            target="_blank"
-            class="js-cluster-application-upgrade-version"
-            >chart v{{ version }}</gl-link
+        <div v-if="updateable">
+          <div
+            v-if="shouldShowUpgradeDetails"
+            class="form-text text-muted label p-0 js-cluster-application-upgrade-details"
           >
-        </div>
+            {{ versionLabel }}
+            <span v-if="updateSuccessful">to</span>
 
-        <div
-          v-if="updateFailed && !isUpgrading"
-          class="bs-callout bs-callout-danger cluster-application-banner mt-2 mb-0 js-cluster-application-upgrade-failure-message"
-        >
-          {{ upgradeFailureDescription }}
+            <gl-link
+              v-if="updateSuccessful"
+              :href="chartRepo"
+              target="_blank"
+              class="js-cluster-application-upgrade-version"
+              >chart v{{ version }}</gl-link
+            >
+          </div>
+
+          <div
+            v-if="updateFailed && !isUpgrading"
+            class="bs-callout bs-callout-danger cluster-application-banner mt-2 mb-0 js-cluster-application-upgrade-failure-message"
+          >
+            {{ upgradeFailureDescription }}
+          </div>
+          <loading-button
+            v-if="upgradeAvailable || updateFailed || isUpgrading"
+            class="btn btn-primary js-cluster-application-upgrade-button mt-2"
+            :loading="isUpgrading"
+            :disabled="isUpgrading"
+            :label="upgradeButtonLabel"
+            @click="upgradeClicked"
+          />
         </div>
-        <loading-button
-          v-if="upgradeAvailable || updateFailed || isUpgrading"
-          class="btn btn-primary js-cluster-application-upgrade-button mt-2"
-          :loading="isUpgrading"
-          :disabled="isUpgrading"
-          :label="upgradeButtonLabel"
-          @click="upgradeClicked"
-        />
       </div>
       <div
         :class="{ 'section-25': showManageButton, 'section-15': !showManageButton }"
diff --git a/app/assets/javascripts/clusters/stores/clusters_store.js b/app/assets/javascripts/clusters/stores/clusters_store.js
index 1b4d7e8372c..89e61c10a46 100644
--- a/app/assets/javascripts/clusters/stores/clusters_store.js
+++ b/app/assets/javascripts/clusters/stores/clusters_store.js
@@ -77,6 +77,8 @@ export default class ClusterStore {
           isEditingHostName: false,
           externalIp: null,
           externalHostname: null,
+          updateSuccessful: false,
+          updateFailed: false,
         },
       },
     };
diff --git a/spec/frontend/clusters/stores/clusters_store_spec.js b/spec/frontend/clusters/stores/clusters_store_spec.js
index aa926bb36d7..0d129349799 100644
--- a/spec/frontend/clusters/stores/clusters_store_spec.js
+++ b/spec/frontend/clusters/stores/clusters_store_spec.js
@@ -133,6 +133,8 @@ describe('Clusters Store', () => {
             uninstallable: false,
             uninstallSuccessful: false,
             uninstallFailed: false,
+            updateSuccessful: false,
+            updateFailed: false,
           },
           cert_manager: {
             title: 'Cert-Manager',