From 2f47b6d8e1cf97b3a0797fe9f249aa1ae38fc5a1 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 26 Jun 2020 09:08:59 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/rules.gitlab-ci.yml | 3 +- .../components/details_page/tags_list.vue | 73 +++++ .../components/details_page/tags_list_row.vue | 129 ++++++++ .../components/details_page/tags_table.vue | 210 ------------- .../explorer/components/list_item.vue | 45 ++- .../components/list_page/image_list_row.vue | 3 +- .../registry/explorer/constants/details.js | 21 +- .../registry/explorer/pages/details.vue | 29 +- ...-from-a-table-to-a-list-view-component.yml | 5 + ...h-fix-any-approvals-with-project-rules.yml | 5 + doc/policy/maintenance.md | 4 +- locale/gitlab.pot | 21 +- .../groups/imports_controller_spec.rb | 2 +- .../pipelines/tests_controller_spec.rb | 2 +- .../experience_levels_controller_spec.rb | 2 +- .../groups/container_registry_spec.rb | 2 +- .../groups/import_export/import_file_spec.rb | 2 +- .../user_sees_design_activity_spec.rb | 2 +- .../projects/container_registry_spec.rb | 2 +- .../details_page/tags_list_row_spec.js | 221 ++++++++++++++ .../components/details_page/tags_list_spec.js | 138 +++++++++ .../details_page/tags_table_spec.js | 286 ------------------ .../explorer/components/list_item_spec.js | 62 +++- spec/frontend/registry/explorer/mock_data.js | 4 +- .../registry/explorer/pages/details_spec.js | 53 ++-- spec/frontend/registry/explorer/stubs.js | 6 - .../alerts/set_assignees_spec.rb | 2 +- .../update_spec.rb | 2 +- .../resolvers/concerns/looks_ahead_spec.rb | 2 +- .../project_members_resolver_spec.rb | 2 +- .../project_pipeline_resolver_spec.rb | 2 +- spec/graphql/resolvers/users_resolver_spec.rb | 2 +- spec/graphql/types/access_level_enum_spec.rb | 2 +- spec/graphql/types/access_level_type_spec.rb | 2 +- spec/graphql/types/evidence_type_spec.rb | 2 +- spec/graphql/types/group_member_type_spec.rb | 2 +- .../types/milestone_stats_type_spec.rb | 2 +- .../graphql/types/project_member_type_spec.rb | 2 +- .../types/release_asset_link_type_spec.rb | 2 +- .../snippets/file_input_action_enum_spec.rb | 2 +- .../types/snippets/file_input_type_spec.rb | 2 +- spec/graphql/types/untrusted_regexp_spec.rb | 2 +- .../analytics/unique_visits_helper_spec.rb | 2 +- .../subscribable_banner_helper_spec.rb | 2 +- spec/lib/api/entities/deploy_key_spec.rb | 2 +- .../api/entities/deploy_keys_project_spec.rb | 2 +- spec/lib/api/entities/ssh_key_spec.rb | 2 +- .../validators/untrusted_regexp_spec.rb | 2 +- .../adf_to_commonmark_filter_spec.rb | 2 +- .../adf_commonmark_pipeline_spec.rb | 2 +- spec/lib/extracts_ref_spec.rb | 2 +- .../gitlab/analytics/unique_visits_spec.rb | 2 +- spec/lib/gitlab/ci/build/releaser_spec.rb | 2 +- .../ci/reports/test_report_summary_spec.rb | 2 +- .../ci/reports/test_suite_summary_spec.rb | 2 +- spec/lib/gitlab/data_builder/alert_spec.rb | 2 +- .../gitlab/database/custom_structure_spec.rb | 2 +- .../database/dynamic_model_helpers_spec.rb | 2 +- .../background_migration_helpers_spec.rb | 2 +- .../backfill_partitioned_table_spec.rb | 2 +- .../dependency_linker/go_mod_linker_spec.rb | 2 +- .../dependency_linker/go_sum_linker_spec.rb | 2 +- spec/lib/gitlab/diff/stats_cache_spec.rb | 2 +- spec/lib/gitlab/doctor/secrets_spec.rb | 2 +- spec/lib/gitlab/emoji_spec.rb | 2 +- spec/lib/gitlab/git_access_project_spec.rb | 2 +- .../lib/gitlab/graphql/mount_mutation_spec.rb | 2 +- .../gitlab/instrumentation/redis_base_spec.rb | 2 +- .../redis_cluster_validator_spec.rb | 2 +- .../dashboard/stages/url_validator_spec.rb | 2 +- .../stages/variable_endpoint_inserter_spec.rb | 2 +- .../gitlab/suggestions/commit_message_spec.rb | 2 +- .../suggestions/file_suggestion_spec.rb | 2 +- .../gitlab/suggestions/suggestion_set_spec.rb | 2 +- .../usage_data_concerns/topology_spec.rb | 2 +- .../parser/atlassian_document_format_spec.rb | 2 +- spec/lib/learn_gitlab_spec.rb | 2 +- ...ule_name_for_code_owners_rule_type_spec.rb | 2 +- ..._settings_to_all_existing_projects_spec.rb | 2 +- ...fill_imported_snippet_repositories_spec.rb | 2 +- ...signs_filename_length_to_new_limit_spec.rb | 2 +- ..._found_group_and_orphaned_projects_spec.rb | 2 +- .../alert_user_mention_spec.rb | 2 +- spec/models/blob_viewer/go_mod_spec.rb | 2 +- spec/models/group_deploy_key_spec.rb | 2 +- spec/models/group_import_state_spec.rb | 2 +- .../chat_message/alert_message_spec.rb | 2 +- spec/models/snippet_statistics_spec.rb | 2 +- .../presenters/gitlab/blame_presenter_spec.rb | 2 +- .../alerts/set_assignees_spec.rb | 2 +- .../update_spec.rb | 2 +- .../jira_import/import_users_spec.rb | 2 +- .../dashboard/annotations/delete_spec.rb | 2 +- .../alert_management/alert/assignees_spec.rb | 2 +- .../alert_management/alert/notes_spec.rb | 2 +- .../api/graphql/project/pipeline_spec.rb | 2 +- .../api/graphql/project/releases_spec.rb | 2 +- .../graphql/user/group_member_query_spec.rb | 2 +- .../graphql/user/project_member_query_spec.rb | 2 +- spec/requests/api/graphql/users_spec.rb | 2 +- spec/routing/routing_spec.rb | 2 +- spec/rubocop/cop/default_scope_spec.rb | 2 +- spec/rubocop/cop/gitlab/bulk_insert_spec.rb | 2 +- spec/rubocop/cop/migration/drop_table_spec.rb | 2 +- ...y_build_group_report_result_entity_spec.rb | 2 +- ...ild_group_report_result_serializer_spec.rb | 2 +- .../bitbucket_provider_repo_entity_spec.rb | 2 +- ...bucket_server_provider_repo_entity_spec.rb | 2 +- .../fogbugz_provider_repo_entity_spec.rb | 2 +- .../githubish_provider_repo_entity_spec.rb | 2 +- .../gitlab_provider_repo_entity_spec.rb | 2 +- .../import/provider_repo_serializer_spec.rb | 2 +- .../alerts/update_service_spec.rb | 2 +- .../periodic_recalculate_service_spec.rb | 2 +- .../project_group_link_create_service_spec.rb | 2 +- ...recalculate_for_user_range_service_spec.rb | 2 +- .../parameter_content_spec.rb | 2 +- .../update_service_spec.rb | 2 +- .../services/gpg_keys/destroy_service_spec.rb | 2 +- .../integrations/test/project_service_spec.rb | 2 +- spec/spec_helper.rb | 2 + .../array_members_validator_spec.rb | 2 +- .../import_csv/_button.html.haml_spec.rb | 2 +- .../periodic_recalculate_worker_spec.rb | 2 +- .../project_group_link_create_worker_spec.rb | 2 +- ...ser_refresh_over_user_range_worker_spec.rb | 2 +- .../stuck_project_import_jobs_worker_spec.rb | 2 +- spec/workers/irker_worker_spec.rb | 2 +- .../prune_old_annotations_worker_spec.rb | 2 +- .../remove_expired_group_links_worker_spec.rb | 2 +- .../remove_expired_members_worker_spec.rb | 2 +- ...ve_unreferenced_lfs_objects_worker_spec.rb | 2 +- .../repository_check/batch_worker_spec.rb | 2 +- .../repository_check/clear_worker_spec.rb | 2 +- .../repository_check/dispatch_worker_spec.rb | 2 +- .../single_repository_worker_spec.rb | 2 +- .../workers/repository_cleanup_worker_spec.rb | 2 +- spec/workers/repository_fork_worker_spec.rb | 2 +- spec/workers/repository_import_worker_spec.rb | 2 +- .../repository_remove_remote_worker_spec.rb | 2 +- ...sitory_update_remote_mirror_worker_spec.rb | 2 +- .../run_pipeline_schedule_worker_spec.rb | 2 +- ...dule_migrate_external_diffs_worker_spec.rb | 2 +- ...f_monitoring_project_create_worker_spec.rb | 2 +- ...f_monitoring_project_delete_worker_spec.rb | 2 +- spec/workers/stage_update_worker_spec.rb | 2 +- spec/workers/stuck_ci_jobs_worker_spec.rb | 2 +- spec/workers/stuck_export_jobs_worker_spec.rb | 2 +- spec/workers/stuck_import_jobs_worker_spec.rb | 2 +- spec/workers/stuck_merge_jobs_worker_spec.rb | 2 +- spec/workers/system_hook_push_worker_spec.rb | 2 +- .../confidential_issue_worker_spec.rb | 2 +- .../entity_leave_worker_spec.rb | 2 +- .../group_private_worker_spec.rb | 2 +- .../private_features_worker_spec.rb | 2 +- .../project_private_worker_spec.rb | 2 +- spec/workers/trending_projects_worker_spec.rb | 2 +- ...date_external_pull_requests_worker_spec.rb | 2 +- ..._pipeline_for_merge_request_worker_spec.rb | 2 +- .../update_highest_role_worker_spec.rb | 2 +- .../update_merge_requests_worker_spec.rb | 2 +- .../update_project_statistics_worker_spec.rb | 2 +- spec/workers/upload_checksum_worker_spec.rb | 2 +- .../users/create_statistics_worker_spec.rb | 2 +- .../wait_for_cluster_creation_worker_spec.rb | 2 +- .../x509_certificate_revoke_worker_spec.rb | 2 +- .../x509_issuer_crl_check_worker_spec.rb | 2 +- 167 files changed, 871 insertions(+), 743 deletions(-) create mode 100644 app/assets/javascripts/registry/explorer/components/details_page/tags_list.vue create mode 100644 app/assets/javascripts/registry/explorer/components/details_page/tags_list_row.vue delete mode 100644 app/assets/javascripts/registry/explorer/components/details_page/tags_table.vue create mode 100644 changelogs/unreleased/216931-convert-the-image-tag-ui-from-a-table-to-a-list-view-component.yml create mode 100644 changelogs/unreleased/sh-fix-any-approvals-with-project-rules.yml create mode 100644 spec/frontend/registry/explorer/components/details_page/tags_list_row_spec.js create mode 100644 spec/frontend/registry/explorer/components/details_page/tags_list_spec.js delete mode 100644 spec/frontend/registry/explorer/components/details_page/tags_table_spec.js diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 2caa57141e5..43b55245e51 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -112,9 +112,10 @@ - "Gemfile{,.lock}" - "Rakefile" - "config.ru" - # List explicitly all the app/ dirs that aren't backend (i.e. all except app/assets). + # List explicitly all the app/ dirs that are backend (i.e. all except app/assets). - "{,ee/}{app/channels,app/controllers,app/finders,app/graphql,app/helpers,app/mailers,app/models,app/policies,app/presenters,app/serializers,app/services,app/uploaders,app/validators,app/views,app/workers}/**/*" - "{,ee/}{bin,cable,config,db,lib}/**/*" + - "{,ee/}spec/**/*.rb" .db-patterns: &db-patterns - "{,ee/}{db}/**/*" diff --git a/app/assets/javascripts/registry/explorer/components/details_page/tags_list.vue b/app/assets/javascripts/registry/explorer/components/details_page/tags_list.vue new file mode 100644 index 00000000000..aaecc91162c --- /dev/null +++ b/app/assets/javascripts/registry/explorer/components/details_page/tags_list.vue @@ -0,0 +1,73 @@ + + + diff --git a/app/assets/javascripts/registry/explorer/components/details_page/tags_list_row.vue b/app/assets/javascripts/registry/explorer/components/details_page/tags_list_row.vue new file mode 100644 index 00000000000..32698c2b139 --- /dev/null +++ b/app/assets/javascripts/registry/explorer/components/details_page/tags_list_row.vue @@ -0,0 +1,129 @@ + + + diff --git a/app/assets/javascripts/registry/explorer/components/details_page/tags_table.vue b/app/assets/javascripts/registry/explorer/components/details_page/tags_table.vue deleted file mode 100644 index 81be778e1e5..00000000000 --- a/app/assets/javascripts/registry/explorer/components/details_page/tags_table.vue +++ /dev/null @@ -1,210 +0,0 @@ - - - diff --git a/app/assets/javascripts/registry/explorer/components/list_item.vue b/app/assets/javascripts/registry/explorer/components/list_item.vue index bf56db3126b..c31a8486731 100644 --- a/app/assets/javascripts/registry/explorer/components/list_item.vue +++ b/app/assets/javascripts/registry/explorer/components/list_item.vue @@ -12,12 +12,19 @@ export default { default: false, required: false, }, + selected: { + type: Boolean, + default: false, + required: false, + }, }, computed: { optionalClasses() { return { 'gl-border-t-solid gl-border-t-1': this.index === 0, 'disabled-content': this.disabled, + 'gl-border-gray-200': !this.selected, + 'gl-bg-blue-50 gl-border-blue-200': this.selected, }; }, }, @@ -26,22 +33,36 @@ export default { diff --git a/app/assets/javascripts/registry/explorer/components/list_page/image_list_row.vue b/app/assets/javascripts/registry/explorer/components/list_page/image_list_row.vue index 3e17518da1e..74ac66cac6d 100644 --- a/app/assets/javascripts/registry/explorer/components/list_page/image_list_row.vue +++ b/app/assets/javascripts/registry/explorer/components/list_page/image_list_row.vue @@ -106,9 +106,8 @@ export default { -