Improve empty state for starred projects

In this MR, a view for the empty state of projects has been added.
In addition, an svg for this has also been added.
This commit is contained in:
Brandon Labuschagne 2019-02-19 15:01:58 +00:00 committed by Kushal Pandya
parent 1aae24ce09
commit 2fd0d6e29b
5 changed files with 34 additions and 6 deletions

View File

@ -0,0 +1,9 @@
.row.empty-state
.col-12
.svg-content.svg-250
= image_tag 'illustrations/starred_empty.svg'
.text-content
%h4.text-center
= s_("StarredProjectsEmptyState|You don't have starred projects yet.")
%p.text-secondary
= s_("StarredProjectsEmptyState|Visit a project page and press on a star icon. Then, you can find the project on this page.")

View File

@ -1,8 +1,8 @@
- @hide_top_links = true
- @no_container = true
- breadcrumb_title "Projects"
- page_title "Starred Projects"
- header_title "Projects", dashboard_projects_path
- breadcrumb_title _("Projects")
- page_title _("Starred Projects")
- header_title _("Projects"), dashboard_projects_path
= render_if_exists "shared/gold_trial_callout"
@ -13,5 +13,4 @@
- if params[:filter_projects] || any_projects?(@projects)
= render 'projects'
- else
%h3.page-title You don't have starred projects yet
%p.slead Visit project page and press on star icon and it will appear on this page.
= render 'starred_empty_state'

View File

@ -0,0 +1,5 @@
---
title: Improve empty state for starred projects
merge_request: 25138
author:
type: changed

View File

@ -7003,6 +7003,12 @@ msgstr ""
msgid "Starred projects"
msgstr ""
msgid "StarredProjectsEmptyState|Visit a project page and press on a star icon. Then, you can find the project on this page."
msgstr ""
msgid "StarredProjectsEmptyState|You don't have starred projects yet."
msgstr ""
msgid "Stars"
msgstr ""

View File

@ -114,7 +114,16 @@ describe 'Dashboard Projects' do
end
end
context 'when on Starred projects tab' do
context 'when on Starred projects tab', :js do
it 'shows the empty state when there are no starred projects' do
visit(starred_dashboard_projects_path)
element = page.find('.row.empty-state')
expect(element).to have_content("You don't have starred projects yet.")
expect(element.find('.svg-content img')['src']).to have_content('illustrations/starred_empty')
end
it 'shows only starred projects' do
user.toggle_star(project2)