Merge branch 'fix-failed-email-for-external-jobs' into 'master'
External jobs do not have show page nor traces Fixes #24677 See merge request !7617
This commit is contained in:
commit
30c122e224
|
@ -135,15 +135,19 @@ class CommitStatus < ActiveRecord::Base
|
|||
allow_failure? && (failed? || canceled?)
|
||||
end
|
||||
|
||||
def playable?
|
||||
false
|
||||
end
|
||||
|
||||
def duration
|
||||
calculate_duration
|
||||
end
|
||||
|
||||
def playable?
|
||||
false
|
||||
end
|
||||
|
||||
def stuck?
|
||||
false
|
||||
end
|
||||
|
||||
def has_trace?
|
||||
false
|
||||
end
|
||||
end
|
||||
|
|
|
@ -0,0 +1,2 @@
|
|||
%a{href: pipeline_build_url(pipeline, build), style: "color:#3777b0;text-decoration:none;"}
|
||||
= build.name
|
|
@ -0,0 +1 @@
|
|||
Build #<%= build.id %> ( <%= pipeline_build_url(pipeline, build) %> )
|
|
@ -0,0 +1 @@
|
|||
= build.name
|
|
@ -0,0 +1 @@
|
|||
Build #<%= build.id %>
|
|
@ -158,12 +158,14 @@
|
|||
%td{style: "font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;color:#8c8c8c;font-weight:500;font-size:15px;vertical-align:middle;"}
|
||||
= build.stage
|
||||
%td{align: "right", style: "font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;padding:20px 0;color:#8c8c8c;font-weight:500;font-size:15px;"}
|
||||
%a{href: pipeline_build_url(@pipeline, build), style: "color:#3777b0;text-decoration:none;"}
|
||||
= build.name
|
||||
= render "notify/links/#{build.to_partial_path}", pipeline: @pipeline, build: build
|
||||
%tr.build-log
|
||||
%td{colspan: "2", style: "font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;padding:0 0 15px;"}
|
||||
%pre{style: "font-family:Monaco,'Lucida Console','Courier New',Courier,monospace;background-color:#fafafa;border-radius:3px;overflow:hidden;white-space:pre-wrap;word-break:break-all;font-size:13px;line-height:1.4;padding:12px;color:#333333;margin:0;"}
|
||||
= build.trace_html(last_lines: 10).html_safe
|
||||
- if build.has_trace?
|
||||
%td{colspan: "2", style: "font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;padding:0 0 15px;"}
|
||||
%pre{style: "font-family:Monaco,'Lucida Console','Courier New',Courier,monospace;background-color:#fafafa;border-radius:3px;overflow:hidden;white-space:pre-wrap;word-break:break-all;font-size:13px;line-height:1.4;padding:12px;color:#333333;margin:0;"}
|
||||
= build.trace_html(last_lines: 10).html_safe
|
||||
- else
|
||||
%td{colspan: "2"}
|
||||
%tr.footer
|
||||
%td{style: "font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;padding:25px 0;font-size:13px;line-height:1.6;color:#5c5c5c;"}
|
||||
%img{alt: "GitLab", height: "33", src: image_url('mailers/ci_pipeline_notif_v1/gitlab-logo-full-horizontal.gif'), style: "display:block;margin:0 auto 1em;", width: "90"}/
|
||||
|
|
|
@ -19,10 +19,12 @@ Commit Author: <%= commit.author_name %>
|
|||
Pipeline #<%= @pipeline.id %> ( <%= pipeline_url(@pipeline) %> ) had <%= failed.size %> failed <%= 'build'.pluralize(failed.size) %>.
|
||||
|
||||
<% failed.each do |build| -%>
|
||||
Build #<%= build.id %> ( <%= pipeline_build_url(@pipeline, build) %> )
|
||||
<%= render "notify/links/#{build.to_partial_path}", pipeline: @pipeline, build: build %>
|
||||
Stage: <%= build.stage %>
|
||||
Name: <%= build.name %>
|
||||
<% if build.has_trace? -%>
|
||||
Trace: <%= build.trace_with_state(last_lines: 10)[:text] %>
|
||||
<% end -%>
|
||||
|
||||
<% end -%>
|
||||
|
||||
|
|
|
@ -571,6 +571,9 @@ describe Ci::Pipeline, models: true do
|
|||
context 'with failed pipeline' do
|
||||
before do
|
||||
perform_enqueued_jobs do
|
||||
create(:ci_build, :failed, pipeline: pipeline)
|
||||
create(:generic_commit_status, :failed, pipeline: pipeline)
|
||||
|
||||
pipeline.drop
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue