kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Run least expensive method first - has_metrics?

Browse source 
Success is relatively cheap compared to prometheus_adapter which can
invoke deployment_platform which does a lot of work
This commit is contained in:
Thong Kuah 2019-06-20 14:25:31 +12:00
parent 65b6a37fa6
commit 3129cbd555
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/deployment.rb
View file

@ -179,7 +179,7 @@ class Deployment < ApplicationRecord
end
def has_metrics?
prometheus_adapter&.can_query? && success?
success? && prometheus_adapter&.can_query?
end
def metrics