kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix gl_dropdown scrolling to top on assignee click

Browse source 
**How?**
It looks like when assignees are clicked, the child of the `<a>`.
We fix our propogation check by looking at `.closest` which traverses
through the element itself and parent.
This commit is contained in:
Paul Slaughter 2019-06-11 10:51:57 -05:00
parent c3e825e01e
commit 3130572f92
No known key found for this signature in database
GPG key ID: DF5690803C68282A
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/assets/javascripts/gl_dropdown.js
View file

@ -567,7 +567,7 @@ GitLabDropdown = (function() {
e.stopPropagation(); e.stopPropagation();
// This prevents automatic scrolling to the top // This prevents automatic scrolling to the top
if ($target.is('a')) { if ($target.closest('a').length) {
return false; return false;
} }
} }

5
changelogs/unreleased/fe-fix-gl-dropdown-scrolling-to-top.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Fix scrolling to top on assignee change
merge_request: 29500
author:
type: fixed