Make model sanitization methods one liners

This commit is contained in:
Felipe Artur 2016-05-09 11:58:20 -03:00
parent d028863eda
commit 32811d98fe
3 changed files with 5 additions and 6 deletions

View File

@ -10,6 +10,7 @@ v 8.8.0 (unreleased)
- Add 'l' shortcut to open Label dropdown on issuables and 'i' to create new issue on a project
- Updated search UI
- Display informative message when new milestone is created
- Sanitize milestones and labels titles
- Allow "NEWS" and "CHANGES" as alternative names for CHANGELOG. !3768 (Connor Shea)
- Added button to toggle whitespaces changes on diff view
- Backport GitLab Enterprise support from EE

View File

@ -117,9 +117,8 @@ class Label < ActiveRecord::Base
LabelsHelper::text_color_for_bg(self.color)
end
def title= value
value = Sanitize.clean(value.to_s) if value
write_attribute(:title, Sanitize.clean(value))
def title=(value)
write_attribute(:title, Sanitize.clean(value.to_s)) if value.present?
end
private

View File

@ -129,9 +129,8 @@ class Milestone < ActiveRecord::Base
nil
end
def title= value
value = Sanitize.clean(value.to_s) if value
write_attribute(:title, value)
def title=(value)
write_attribute(:title, Sanitize.clean(value.to_s)) if value.present?
end
# Sorts the issues for the given IDs.