Treat element#selector_css string appropriately

Proper escaping should be used for page/base.rb#scroll_to
as it is a single quoted JS string
This commit is contained in:
ddavison 2019-07-10 16:20:31 -07:00
parent 015b61b1dc
commit 3281e6db23
No known key found for this signature in database
GPG Key ID: 29F0AE2EFEDC3121
2 changed files with 2 additions and 2 deletions

View File

@ -28,7 +28,7 @@ module QA
end
def selector_css
"[data-qa-selector='#{@name}'],.#{selector}"
%Q([data-qa-selector="#{@name}"],.#{selector})
end
def expression

View File

@ -114,7 +114,7 @@ describe QA::Page::Element do
describe 'data-qa selectors' do
subject { described_class.new(:my_element) }
it 'properly translates to a data-qa-selector' do
expect(subject.selector_css).to include("[data-qa-selector='my_element']")
expect(subject.selector_css).to include(%q([data-qa-selector="my_element"]))
end
end
end