Treat element#selector_css string appropriately
Proper escaping should be used for page/base.rb#scroll_to as it is a single quoted JS string
This commit is contained in:
parent
015b61b1dc
commit
3281e6db23
|
@ -28,7 +28,7 @@ module QA
|
|||
end
|
||||
|
||||
def selector_css
|
||||
"[data-qa-selector='#{@name}'],.#{selector}"
|
||||
%Q([data-qa-selector="#{@name}"],.#{selector})
|
||||
end
|
||||
|
||||
def expression
|
||||
|
|
|
@ -114,7 +114,7 @@ describe QA::Page::Element do
|
|||
describe 'data-qa selectors' do
|
||||
subject { described_class.new(:my_element) }
|
||||
it 'properly translates to a data-qa-selector' do
|
||||
expect(subject.selector_css).to include("[data-qa-selector='my_element']")
|
||||
expect(subject.selector_css).to include(%q([data-qa-selector="my_element"]))
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue