Don't return nil for missing objects from parser cache

This commit is contained in:
Douwe Maan 2017-06-14 12:54:59 -05:00
parent 5771b946c2
commit 338d9b257e
3 changed files with 6 additions and 2 deletions

View file

@ -0,0 +1,4 @@
---
title: Don't return nil for missing objects from parser cache
merge_request:
author:

View file

@ -171,7 +171,7 @@ module Banzai
collection.where(id: to_query).each { |row| cache[row.id] = row }
end
cache.values_at(*ids)
cache.values_at(*ids).compact
else
collection.where(id: ids)
end

View file

@ -114,7 +114,7 @@ describe Banzai::ReferenceParser::BaseParser, lib: true do
expect(hash).to eq({ link => user })
end
it 'returns an empty Hash when entry does not exist in the database' do
it 'returns an empty Hash when entry does not exist in the database', :request_store do
link = double(:link)
expect(link).to receive(:has_attribute?).