kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Make sessions controller specs more explicit

Browse source
This commit is contained in:
Grzegorz Bizon 2016-04-07 11:45:04 +02:00
parent 00da609cfd
commit 33a8dfd04f
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
spec/controllers/sessions_controller_spec.rb
View file

@ -69,7 +69,7 @@ describe SessionsController do
end
end
context ' when OTP is invalid' do
context 'when OTP is invalid' do
before { authenticate_2fa(otp_attempt: 'invalid') }
it 'does not authenticate' do
@ -77,8 +77,8 @@ describe SessionsController do
end
it 'warns about invalid OTP code' do
expect(response).to set_flash
.now[:alert].to /Invalid two-factor code/
expect(response).to set_flash.now[:alert]
.to /Invalid two-factor code/
end
end
end
@ -90,7 +90,8 @@ describe SessionsController do
authenticate_2fa(login: another_user.username,
otp_attempt: 'invalid')
expect(response).to_not set_flash.now[:alert].to /Invalid login or password/
expect(response).to set_flash.now[:alert]
.to /Invalid two-factor code/
end
end
end