kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Dryed code in commit_item by adding another computed prop

Browse source
This commit is contained in:
Tim Zallmann 2019-01-07 11:04:59 +01:00
parent 30038a40b0
commit 33cfeea176
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
app/assets/javascripts/diffs/components/commit_item.vue
View file

@ -36,24 +36,23 @@ export default {
},
},
computed: {
author() {
return this.commit.author || {};
},
authorName() {
return (this.commit.author && this.commit.author.name) || this.commit.author_name;
return this.author.name || this.commit.author_name;
},
authorClass() {
return this.commit.author && this.commit.author.name ? 'js-user-link' : '';
return this.author.name ? 'js-user-link' : '';
},
authorId() {
return this.commit.author && this.commit.author.name ? this.commit.author.id : '';
return this.author.id ? this.author.id : '';
},
authorUrl() {
return (
(this.commit.author && this.commit.author.web_url) || `mailto:${this.commit.author_email}`
);
return this.author.web_url || `mailto:${this.commit.author_email}`;
},
authorAvatar() {
return (
(this.commit.author && this.commit.author.avatar_url) || this.commit.author_gravatar_url
);
return this.author.avatar_url || this.commit.author_gravatar_url;
},
},
created() {