Move Ci::BuildMetadata#update_timeout_state to after_transition callback

This commit is contained in:
Tomasz Maczukin 2018-04-17 15:51:53 +02:00
parent fe9c9ad2fe
commit 33de331985
No known key found for this signature in database
GPG Key ID: 7E9EB2E4B0F625CD
2 changed files with 1 additions and 5 deletions

View File

@ -162,7 +162,7 @@ module Ci
build.validates_dependencies! unless Feature.enabled?('ci_disable_validates_dependencies')
end
before_transition pending: :running do |build|
after_transition pending: :running do |build|
build.ensure_metadata.update_timeout_state
end
end

View File

@ -2140,10 +2140,6 @@ describe Ci::Build do
it "doesn't save timeout_source" do
expect { run_job_without_exception }.not_to change { job.reload.ensure_metadata.timeout_source }
end
it 'raises an exception' do
expect { job.run! }.to raise_error(StateMachines::InvalidTransition)
end
end
end