diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 25ea2211b64..f45de25aee5 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -132,6 +132,13 @@ If a developer who happens to also be a maintainer was involved in a merge reque as a domain expert and/or reviewer, it is recommended that they are not also picked as the maintainer to ultimately approve and merge it. +Try to review in a timely manner; doing so allows everyone involved in the merge +request to iterate faster as the context is fresh in memory. Further, this +improves contributors' experiences significantly. Provided full availability; +reviewing within two work days should be the aim. If you don't think you'll be +able to review a merge request within that time, let the author know as soon as +possible. + Maintainers should check before merging if the merge request is approved by the required approvers.