kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Use a hash to memoize readable_project_ids with user objects as keys

Browse source
This commit is contained in:
Reuben Pereira 2018-07-31 00:48:59 +05:30
parent 8cc646fa0e
commit 34e912b538
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/banzai/reference_parser/project_parser.rb
View file

@ -13,16 +13,15 @@ module Banzai
# Returns an Array of Project ids that can be read by the given user.
#
# projects - The projects to reduce down to those readable by the user.
# user - The User for which to check the projects
def readable_project_ids_for(projects, user)
strong_memoize(:readable_project_ids_for) do
Project.public_or_visible_to_user(user).where("projects.id IN (?)", projects.map(&:id)).pluck(:id)
end
def readable_project_ids_for(user)
@project_ids_by_user ||= {}
@project_ids_by_user[user] ||=
Project.public_or_visible_to_user(user).where("projects.id IN (?)", @projects_for_nodes.values.map(&:id)).pluck(:id)
end
def can_read_reference?(user, ref_project, node)
readable_project_ids_for(@projects_for_nodes.values, user).include?(ref_project.try(:id))
readable_project_ids_for(user).include?(ref_project.try(:id))
end
end
end