kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add retry to system hook worker

Browse source 
The default number of Sidekiq retries is 25 over about 21 days.
If an external system is unavailable for a length of time, hooks
can pile up in the Sidekiq queues. If the situation gets bad enough
the retry jobs dropping back into the main queue can slow down
other jobs. Limit the retries to a sane number to avoid this
scenario.
This commit is contained in:
Drew Blessing 2017-04-19 16:34:26 -05:00
parent 509ff2ab17
commit 354e37b869
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/workers/system_hook_worker.rb
View file

@ -2,6 +2,8 @@ class SystemHookWorker
include Sidekiq::Worker include Sidekiq::Worker
include DedicatedSidekiqQueue include DedicatedSidekiqQueue
sidekiq_options retry: 4
def perform(hook_id, data, hook_name) def perform(hook_id, data, hook_name)
SystemHook.find(hook_id).execute(data, hook_name) SystemHook.find(hook_id).execute(data, hook_name)
end end

4
changelogs/unreleased/hook_retries.yml Normal file
View file

@ -0,0 +1,4 @@
---
title: Add retry to system hook worker
merge_request: 10801
author: