kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Refactor tests for #opensInNewTab

Browse source
This commit is contained in:
Kushal Pandya 2017-02-07 21:40:31 +05:30
parent a11b23046f
commit 3633e04fcd
1 changed files with 3 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
spec/javascripts/merge_request_tabs_spec.js
View file

@ -62,7 +62,7 @@ require('vendor/jquery.scrollTo');
}); });
}); });
describe('#opensInNewTab', function () { describe('#opensInNewTab', function () {
it('opens page tab in a new browser tab with Ctrl+Click - Windows/Linux', function () { beforeEach(function () {
const commitsLink = '.commits-tab li a'; const commitsLink = '.commits-tab li a';
const tabUrl = $(commitsLink).attr('href'); const tabUrl = $(commitsLink).attr('href');
@ -71,7 +71,8 @@ require('vendor/jquery.scrollTo');
expect(url).toEqual(tabUrl); expect(url).toEqual(tabUrl);
expect(name).toEqual('_blank'); expect(name).toEqual('_blank');
}); });
});
it('opens page tab in a new browser tab with Ctrl+Click - Windows/Linux', function () {
this.class.clickTab({ this.class.clickTab({
metaKey: false, metaKey: false,
ctrlKey: true, ctrlKey: true,
@ -80,15 +81,6 @@ require('vendor/jquery.scrollTo');
}); });
}); });
it('opens page tab in a new browser tab with Cmd+Click - Mac', function () { it('opens page tab in a new browser tab with Cmd+Click - Mac', function () {
const commitsLink = '.commits-tab li a';
const tabUrl = $(commitsLink).attr('href');
spyOn($.fn, 'attr').and.returnValue(tabUrl);
spyOn(window, 'open').and.callFake(function (url, target) {
expect(url).toEqual(tabUrl);
expect(target).toEqual('_blank');
});
this.class.clickTab({ this.class.clickTab({
metaKey: true, metaKey: true,
ctrlKey: false, ctrlKey: false,
@ -97,15 +89,6 @@ require('vendor/jquery.scrollTo');
}); });
}); });
it('opens page tab in a new browser tab with Middle-click - Mac/PC', function () { it('opens page tab in a new browser tab with Middle-click - Mac/PC', function () {
const commitsLink = '.commits-tab li a';
const tabUrl = $(commitsLink).attr('href');
spyOn($.fn, 'attr').and.returnValue(tabUrl);
spyOn(window, 'open').and.callFake(function (url, target) {
expect(url).toEqual(tabUrl);
expect(target).toEqual('_blank');
});
this.class.clickTab({ this.class.clickTab({
metaKey: false, metaKey: false,
ctrlKey: false, ctrlKey: false,