diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 589f98c9e02..4c1c8430204 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -156,7 +156,6 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - - 'lib/gitlab/background_migration/migrate_stage_status.rb' - 'lib/gitlab/background_migration/migrate_u2f_webauthn.rb' - 'lib/gitlab/background_migration/populate_latest_pipeline_ids.rb' - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' @@ -182,7 +181,6 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/patch/action_cable_redis_listener.rb' - 'lib/gitlab/patch/prependable.rb' - 'lib/gitlab/project_search_results.rb' - - 'lib/gitlab/task_helpers.rb' - 'lib/gitlab/testing/request_blocker_middleware.rb' - 'lib/gitlab/testing/request_inspector_middleware.rb' - 'lib/gitlab/testing/robots_blocker_middleware.rb' @@ -192,4 +190,4 @@ Lint/MissingCopEnableDirective: - 'spec/support/capybara.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/product_intelligence.rb' \ No newline at end of file diff --git a/.rubocop_todo/lint/mixed_regexp_capture_types.yml b/.rubocop_todo/lint/mixed_regexp_capture_types.yml index f9872fdbd7f..3dcb9427ef8 100644 --- a/.rubocop_todo/lint/mixed_regexp_capture_types.yml +++ b/.rubocop_todo/lint/mixed_regexp_capture_types.yml @@ -10,7 +10,6 @@ Lint/MixedRegexpCaptureTypes: - 'lib/gitlab/diff/suggestions_parser.rb' - 'lib/gitlab/github_import/representation/note.rb' - 'lib/gitlab/metrics/system.rb' - - 'lib/gitlab/request_profiler/profile.rb' - 'lib/gitlab/slash_commands/issue_move.rb' - 'lib/gitlab/slash_commands/issue_new.rb' - - 'lib/gitlab/slash_commands/run.rb' + - 'lib/gitlab/slash_commands/run.rb' \ No newline at end of file diff --git a/app/assets/javascripts/batch_comments/components/draft_note.vue b/app/assets/javascripts/batch_comments/components/draft_note.vue index c8130c47f5b..2b1ab911fbe 100644 --- a/app/assets/javascripts/batch_comments/components/draft_note.vue +++ b/app/assets/javascripts/batch_comments/components/draft_note.vue @@ -113,7 +113,7 @@ export default { class="referenced-commands draft-note-commands" > -

+

`startDate` **{warning-solid}** | [`Time`](#time) | **Deprecated** in 13.5. Use timeframe.start. | | `state` | [`EpicState`](#epicstate) | Filter epics by state. | | `timeframe` | [`Timeframe`](#timeframe) | List items overlapping the given timeframe. | +| `topLevelHierarchyOnly` | [`Boolean`](#boolean) | Filter epics with a top-level hierarchy. | | `updatedAfter` | [`Time`](#time) | Epics updated after this date. | | `updatedBefore` | [`Time`](#time) | Epics updated before this date. | @@ -9318,6 +9319,7 @@ four standard [pagination arguments](#connection-pagination-arguments): | `startDate` **{warning-solid}** | [`Time`](#time) | **Deprecated** in 13.5. Use timeframe.start. | | `state` | [`EpicState`](#epicstate) | Filter epics by state. | | `timeframe` | [`Timeframe`](#timeframe) | List items overlapping the given timeframe. | +| `topLevelHierarchyOnly` | [`Boolean`](#boolean) | Filter epics with a top-level hierarchy. | | `updatedAfter` | [`Time`](#time) | Epics updated after this date. | | `updatedBefore` | [`Time`](#time) | Epics updated before this date. | @@ -10858,6 +10860,7 @@ four standard [pagination arguments](#connection-pagination-arguments): | `startDate` **{warning-solid}** | [`Time`](#time) | **Deprecated** in 13.5. Use timeframe.start. | | `state` | [`EpicState`](#epicstate) | Filter epics by state. | | `timeframe` | [`Timeframe`](#timeframe) | List items overlapping the given timeframe. | +| `topLevelHierarchyOnly` | [`Boolean`](#boolean) | Filter epics with a top-level hierarchy. | | `updatedAfter` | [`Time`](#time) | Epics updated after this date. | | `updatedBefore` | [`Time`](#time) | Epics updated before this date. | @@ -10895,6 +10898,7 @@ four standard [pagination arguments](#connection-pagination-arguments): | `startDate` **{warning-solid}** | [`Time`](#time) | **Deprecated** in 13.5. Use timeframe.start. | | `state` | [`EpicState`](#epicstate) | Filter epics by state. | | `timeframe` | [`Timeframe`](#timeframe) | List items overlapping the given timeframe. | +| `topLevelHierarchyOnly` | [`Boolean`](#boolean) | Filter epics with a top-level hierarchy. | | `updatedAfter` | [`Time`](#time) | Epics updated after this date. | | `updatedBefore` | [`Time`](#time) | Epics updated before this date. | @@ -11629,6 +11633,7 @@ Returns [`Epic`](#epic). | `startDate` **{warning-solid}** | [`Time`](#time) | **Deprecated** in 13.5. Use timeframe.start. | | `state` | [`EpicState`](#epicstate) | Filter epics by state. | | `timeframe` | [`Timeframe`](#timeframe) | List items overlapping the given timeframe. | +| `topLevelHierarchyOnly` | [`Boolean`](#boolean) | Filter epics with a top-level hierarchy. | | `updatedAfter` | [`Time`](#time) | Epics updated after this date. | | `updatedBefore` | [`Time`](#time) | Epics updated before this date. | @@ -11678,6 +11683,7 @@ four standard [pagination arguments](#connection-pagination-arguments): | `startDate` **{warning-solid}** | [`Time`](#time) | **Deprecated** in 13.5. Use timeframe.start. | | `state` | [`EpicState`](#epicstate) | Filter epics by state. | | `timeframe` | [`Timeframe`](#timeframe) | List items overlapping the given timeframe. | +| `topLevelHierarchyOnly` | [`Boolean`](#boolean) | Filter epics with a top-level hierarchy. | | `updatedAfter` | [`Time`](#time) | Epics updated after this date. | | `updatedBefore` | [`Time`](#time) | Epics updated before this date. | diff --git a/doc/ci/jobs/index.md b/doc/ci/jobs/index.md index b5d285e6146..1f7a7436c0a 100644 --- a/doc/ci/jobs/index.md +++ b/doc/ci/jobs/index.md @@ -328,7 +328,7 @@ job1: - echo -e "\e[0Ksection_end:`date +%s`:my_first_section\r\e[0K" ``` -Depending on the shell that your runner uses, for example if it is using ZSH, you may need to +Depending on the shell that your runner uses, for example if it is using Zsh, you may need to escape the special characters like so: `\\e` and `\\r`. In the example above: diff --git a/doc/development/audit_event_guide/index.md b/doc/development/audit_event_guide/index.md index 0d62bcdc3b2..0ce1c340a84 100644 --- a/doc/development/audit_event_guide/index.md +++ b/doc/development/audit_event_guide/index.md @@ -14,6 +14,17 @@ new audit events. Audit Events are a tool for GitLab owners and administrators to view records of important actions performed across the application. +## What should NOT be Audit Events? + +While any events could trigger an Audit Event, not all events should. In general, events that are not good candidates for audit events are: + +- Not attributable to one specific user. +- Not of specific interest to an admin or owner persona. +- Are tracking information for product feature adoption. +- Are covered in the direction page's discussion on [what is not planned](https://about.gitlab.com/direction/manage/compliance/audit-events/#what-is-not-planned-right-now). + +If you have any questions, please reach out to `@gitlab-org/manage/compliance` to see if an Audit Event, or some other approach, may be best for your event. + ## Audit Event Schemas To instrument an audit event, the following attributes should be provided: diff --git a/doc/development/cicd/pipeline_wizard.md b/doc/development/cicd/pipeline_wizard.md index f949386ba98..608c21778c0 100644 --- a/doc/development/cicd/pipeline_wizard.md +++ b/doc/development/cicd/pipeline_wizard.md @@ -31,7 +31,7 @@ consists of 2-3 steps, for a total of 3-4 steps visible to the user.