From 36dc28fd5588bc696f6092a17a831fbd6c2f4334 Mon Sep 17 00:00:00 2001 From: Athar Hameed Date: Tue, 24 Apr 2018 12:21:01 +0000 Subject: [PATCH] Fix unassign slash command preview --- app/services/quick_actions/interpret_service.rb | 6 ++++-- .../unreleased/4950-unassign-slash-command-preview-fix.yml | 5 +++++ 2 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 changelogs/unreleased/4950-unassign-slash-command-preview-fix.yml diff --git a/app/services/quick_actions/interpret_service.rb b/app/services/quick_actions/interpret_service.rb index 6cc51b6ee1b..6804dff2a9b 100644 --- a/app/services/quick_actions/interpret_service.rb +++ b/app/services/quick_actions/interpret_service.rb @@ -138,8 +138,10 @@ module QuickActions 'Remove assignee' end end - explanation do - "Removes #{'assignee'.pluralize(issuable.assignees.size)} #{issuable.assignees.map(&:to_reference).to_sentence}." + explanation do |users = nil| + assignees = issuable.assignees + assignees &= users if users.present? && issuable.allows_multiple_assignees? + "Removes #{'assignee'.pluralize(assignees.size)} #{assignees.map(&:to_reference).to_sentence}." end params do issuable.allows_multiple_assignees? ? '@user1 @user2' : '' diff --git a/changelogs/unreleased/4950-unassign-slash-command-preview-fix.yml b/changelogs/unreleased/4950-unassign-slash-command-preview-fix.yml new file mode 100644 index 00000000000..0b8c14ae699 --- /dev/null +++ b/changelogs/unreleased/4950-unassign-slash-command-preview-fix.yml @@ -0,0 +1,5 @@ +--- +title: Fix unassign slash command preview +merge_request: 18447 +author: +type: fixed