Improve after review

doc/ci/yaml/README.md

@@ -670,7 +670,7 @@ failure.
 
 **Example configurations**
 
-To upload artifacts only when build fails
+To upload artifacts only when build fails.
 
 ```yaml
 job:

lib/ci/gitlab_ci_yaml_processor.rb

@@ -208,7 +208,7 @@ module Ci
         raise ValidationError, "#{name} job: allow_failure parameter should be an boolean"
       end
 
-      if job[:when] && !job[:when].in?(%w(on_success on_failure always))
+      if job[:when] && !job[:when].in?(%w[on_success on_failure always])
         raise ValidationError, "#{name} job: when parameter should be on_success, on_failure or always"
       end
     end
@@ -279,7 +279,7 @@ module Ci
         raise ValidationError, "#{name} job: artifacts:paths parameter should be an array of strings"
       end
 
-      if job[:artifacts][:when] && !job[:artifacts][:when].in?(%w(on_success on_failure always))
+      if job[:artifacts][:when] && !job[:artifacts][:when].in?(%w[on_success on_failure always])
         raise ValidationError, "#{name} job: artifacts:when parameter should be on_success, on_failure or always"
       end
     end

spec/lib/ci/gitlab_ci_yaml_processor_spec.rb

@@ -602,7 +602,7 @@ module Ci
         })
       end
 
-      %w(on_success on_failure always).each do |when_state|
+      %w[on_success on_failure always].each do |when_state|
         it "returns artifacts for when #{when_state}  defined" do
           config = YAML.dump({
                                rspec: {
@@ -612,6 +612,7 @@ module Ci
                              })
 
           config_processor = GitlabCiYamlProcessor.new(config, path)
+
           builds = config_processor.builds_for_stage_and_ref("test", "master")
           expect(builds.size).to eq(1)
           expect(builds.first[:options][:artifacts][:when]).to eq(when_state)