From 3729c0822a51c74ac775c84d005f664aca40f3dd Mon Sep 17 00:00:00 2001 From: Jacob Vosmaer Date: Thu, 10 Mar 2016 17:05:36 +0100 Subject: [PATCH] Remove unnecessary random key --- lib/gitlab/exclusive_lease.rb | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/gitlab/exclusive_lease.rb b/lib/gitlab/exclusive_lease.rb index 8bf6f13b99d..324e32a5c68 100644 --- a/lib/gitlab/exclusive_lease.rb +++ b/lib/gitlab/exclusive_lease.rb @@ -1,5 +1,3 @@ -require 'securerandom' - module Gitlab # This class implements an 'exclusive lease'. We call it a 'lease' # because it has a set expiry time. We call it 'exclusive' because only @@ -27,7 +25,7 @@ module Gitlab def try_obtain # This is expected to be atomic because we are talking to a # single-threaded Redis server. - !!redis.set(redis_key, redis_value, nx: true, ex: @timeout) + !!redis.set(redis_key, '1', nx: true, ex: @timeout) end private @@ -40,9 +38,5 @@ module Gitlab def redis_key "gitlab:exclusive_lease:#{@key}" end - - def redis_value - @redis_value ||= SecureRandom.hex(10) - end end end