kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'spec_cluster_policy_coverage' into 'master' 

Improve cluster policy spec coverage

See merge request gitlab-org/gitlab-ce!31700
This commit is contained in:
Bob Van Landuyt 2019-08-13 09:14:06 +00:00
parent 0297f1c2b8 b56f285012
commit 3770f3fb30
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spec/policies/clusters/instance_policy_spec.rb
View File

@ -9,6 +9,8 @@ describe Clusters::InstancePolicy do
describe 'rules' do
context 'when user' do
it { expect(policy).to be_disallowed :read_cluster }
it { expect(policy).to be_disallowed :add_cluster }
it { expect(policy).to be_disallowed :create_cluster }
it { expect(policy).to be_disallowed :update_cluster }
it { expect(policy).to be_disallowed :admin_cluster }
end
@ -17,6 +19,8 @@ describe Clusters::InstancePolicy do
let(:user) { create(:admin) }
it { expect(policy).to be_allowed :read_cluster }
it { expect(policy).to be_allowed :add_cluster }
it { expect(policy).to be_allowed :create_cluster }
it { expect(policy).to be_allowed :update_cluster }
it { expect(policy).to be_allowed :admin_cluster }
end

8
spec/support/shared_examples/policies/clusterable_shared_examples.rb
View File

@ -13,7 +13,11 @@ shared_examples 'clusterable policies' do
clusterable.add_developer(current_user)
end
it { expect_disallowed(:read_cluster) }
it { expect_disallowed(:add_cluster) }
it { expect_disallowed(:create_cluster) }
it { expect_disallowed(:update_cluster) }
it { expect_disallowed(:admin_cluster) }
end
context 'with a maintainer' do
@ -22,7 +26,11 @@ shared_examples 'clusterable policies' do
end
context 'with no clusters' do
it { expect_allowed(:read_cluster) }
it { expect_allowed(:add_cluster) }
it { expect_allowed(:create_cluster) }
it { expect_allowed(:update_cluster) }
it { expect_allowed(:admin_cluster) }
end
end
end