kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Remove Gitaly N+1 ignore from NotificationRecipientService spec 

This was because we were creating projects unnecessarily. These should be set as
the `source` for the notification setting, not the `project`!
This commit is contained in:
Sean McGivern 2018-07-04 16:12:37 +01:00
parent b9b0fc8db1
commit 37a6be36e2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/services/notification_recipient_service_spec.rb
View File

@ -12,15 +12,15 @@ describe NotificationRecipientService do
def create_watcher
watcher = create(:user)
create(:notification_setting, project: project, user: watcher, level: :watch)
create(:notification_setting, source: project, user: watcher, level: :watch)
other_projects.each do |other_project|
create(:notification_setting, project: other_project, user: watcher, level: :watch)
create(:notification_setting, source: other_project, user: watcher, level: :watch)
end
end
it 'avoids N+1 queries', :request_store do
Gitlab::GitalyClient.allow_n_plus_1_calls { create_watcher }
create_watcher
service.build_new_note_recipients(note)
@ -28,7 +28,7 @@ describe NotificationRecipientService do
service.build_new_note_recipients(note)
end
Gitlab::GitalyClient.allow_n_plus_1_calls { create_watcher }
create_watcher
expect { service.build_new_note_recipients(note) }.not_to exceed_query_limit(control_count)
end