kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'bvl-adjust-openid_connect_spec' into 'master' 

Adjust openid_connect_spec to use `raise_error`

Closes #40093

See merge request gitlab-org/gitlab-ce!15420
This commit is contained in:
Sean McGivern 2017-11-16 13:13:53 +00:00
parent c3d8bc3548 a37427f614
commit 37cca88d05
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
spec/requests/openid_connect_spec.rb
View File

@ -107,6 +107,15 @@ describe 'OpenID Connect requests' do
end
end
# These 2 calls shouldn't actually throw, they should be handled as an
# unauthorized request, so we should be able to check the response.
#
# This was not possible due to an issue with Warden:
# https://github.com/hassox/warden/pull/162
#
# When the patch gets merged and we update Warden, these specs will need to
# updated to check the response instead of a raised exception.
# https://gitlab.com/gitlab-org/gitlab-ce/issues/40218
context 'when user is blocked' do
it 'returns authentication error' do
access_grant
@ -114,7 +123,7 @@ describe 'OpenID Connect requests' do
expect do
request_access_token
end.to throw_symbol :warden
end.to raise_error UncaughtThrowError
end
end
@ -125,7 +134,7 @@ describe 'OpenID Connect requests' do
expect do
request_access_token
end.to throw_symbol :warden
end.to raise_error UncaughtThrowError
end
end
end