From 38fb6279f9709e43f80c70c1fd4cccef77963b21 Mon Sep 17 00:00:00 2001
From: Robert Speicher <rspeicher@gmail.com>
Date: Mon, 20 Apr 2015 18:47:22 -0400
Subject: [PATCH] Simplify `cross_project_reference` with `to_reference`

---
 app/helpers/gitlab_markdown_helper.rb | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/app/helpers/gitlab_markdown_helper.rb b/app/helpers/gitlab_markdown_helper.rb
index 7bcc011fd5f..d89f7b4a28d 100644
--- a/app/helpers/gitlab_markdown_helper.rb
+++ b/app/helpers/gitlab_markdown_helper.rb
@@ -135,15 +135,25 @@ module GitlabMarkdownHelper
     end
   end
 
+  # Returns the text necessary to reference `entity` across projects
+  #
+  # project - Project to reference
+  # entity  - Object that responds to `to_reference`
+  #
+  # Examples:
+  #
+  #   cross_project_reference(project, project.issues.first)
+  #   # => 'namespace1/project1#123'
+  #
+  #   cross_project_reference(project, project.merge_requests.first)
+  #   # => 'namespace1/project1!345'
+  #
+  # Returns a String
   def cross_project_reference(project, entity)
-    path = project.path_with_namespace
-
-    if entity.kind_of?(Issue)
-      [path, entity.iid].join('#')
-    elsif entity.kind_of?(MergeRequest)
-      [path, entity.iid].join('!')
+    if entity.respond_to?(:to_reference)
+      "#{project.to_reference}#{entity.to_reference}"
     else
-      raise 'Not supported type'
+      ''
     end
   end
 end