Make tests of Gitlab::Metrics use explicit descriptions.

This commit is contained in:
Pawel Chojnacki 2017-05-23 16:16:23 +02:00
parent ef9f23b797
commit 394e962e52

View file

@ -9,19 +9,19 @@ describe Gitlab::Metrics do
describe '.enabled?' do describe '.enabled?' do
it 'returns a boolean' do it 'returns a boolean' do
expect([true, false].include?(described_class.enabled?)).to eq(true) expect(described_class.enabled?).to be_in([true, false])
end end
end end
describe '.prometheus_metrics_enabled?' do describe '.prometheus_metrics_enabled?' do
it 'returns a boolean' do it 'returns a boolean' do
expect([true, false].include?(described_class.prometheus_metrics_enabled?)).to eq(true) expect(described_class.prometheus_metrics_enabled?).to be_in([true, false])
end end
end end
describe '.influx_metrics_enabled?' do describe '.influx_metrics_enabled?' do
it 'returns a boolean' do it 'returns a boolean' do
expect([true, false].include?(described_class.influx_metrics_enabled?)).to eq(true) expect(described_class.influx_metrics_enabled?).to be_in([true, false])
end end
end end
@ -195,9 +195,17 @@ describe Gitlab::Metrics do
subject { described_class.counter(:couter, 'doc') } subject { described_class.counter(:couter, 'doc') }
describe '#increment' do describe '#increment' do
it { expect { subject.increment }.not_to raise_exception } it 'successfully calls #increment without arguments' do
it { expect { subject.increment({}) }.not_to raise_exception } expect { subject.increment }.not_to raise_exception
it { expect { subject.increment({}, 1) }.not_to raise_exception } end
it 'successfully calls #increment with 1 argument' do
expect { subject.increment({}) }.not_to raise_exception
end
it 'successfully calls #increment with 2 arguments' do
expect { subject.increment({}, 1) }.not_to raise_exception
end
end end
end end
@ -205,15 +213,19 @@ describe Gitlab::Metrics do
subject { described_class.summary(:summary, 'doc') } subject { described_class.summary(:summary, 'doc') }
describe '#observe' do describe '#observe' do
it { expect { subject.observe({}, 2) }.not_to raise_exception } it 'successfully calls #observe with 2 arguments' do
expect { subject.observe({}, 2) }.not_to raise_exception
end
end end
end end
describe '#gauge' do describe '#gauge' do
subject { described_class.gauge(:gauge, 'doc') } subject { described_class.gauge(:gauge, 'doc') }
describe '#observe' do describe '#set' do
it { expect { subject.set({}, 1) }.not_to raise_exception } it 'successfully calls #set with 2 arguments' do
expect { subject.set({}, 1) }.not_to raise_exception
end
end end
end end
@ -221,7 +233,9 @@ describe Gitlab::Metrics do
subject { described_class.histogram(:histogram, 'doc') } subject { described_class.histogram(:histogram, 'doc') }
describe '#observe' do describe '#observe' do
it { expect { subject.observe({}, 2) }.not_to raise_exception } it 'successfully calls #observe with 2 arguments' do
expect { subject.observe({}, 2) }.not_to raise_exception
end
end end
end end
end end