diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 21671ba56ae..534861d90b2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -143,25 +143,6 @@ Performance/ConstantRegexp: Performance/MethodObjectAsBlock: Enabled: false -# Offense count: 18 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect. -Performance/StringInclude: - Exclude: - - 'app/models/snippet_repository.rb' - - 'config/initializers/macos.rb' - - 'config/spring.rb' - - 'ee/app/models/ee/container_registry/event.rb' - - 'ee/lib/gitlab/auth/smartcard/certificate.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/kramdown/parser/atlassian_document_format.rb' - - 'lib/prometheus/pid_provider.rb' - - 'qa/qa/ee/page/merge_request/show.rb' - - 'qa/qa/specs/runner.rb' - - 'spec/features/projects/jobs_spec.rb' - - 'spec/spec_helper.rb' - - 'spec/support_specs/helpers/active_record/query_recorder_spec.rb' - # Offense count: 15209 # Configuration parameters: Prefixes. # Prefixes: when, with, without @@ -282,11 +263,6 @@ Rails/HelperInstanceVariable: Rails/IndexWith: Enabled: false -# Offense count: 1 -Rails/Inquiry: - Exclude: - - 'spec/helpers/labels_helper_spec.rb' - # Offense count: 118 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -335,11 +311,6 @@ Rails/RakeEnvironment: Rails/RedundantForeignKey: Enabled: false -# Offense count: 1 -Rails/RenderInline: - Exclude: - - 'ee/app/controllers/sitemap_controller.rb' - # Offense count: 1144 # Configuration parameters: ForbiddenMethods, AllowedMethods. # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all diff --git a/.rubocop_todo/performance/string_include.yml b/.rubocop_todo/performance/string_include.yml new file mode 100644 index 00000000000..cb6e566094e --- /dev/null +++ b/.rubocop_todo/performance/string_include.yml @@ -0,0 +1,15 @@ +--- +# Cop supports --auto-correct. +Performance/StringInclude: + Exclude: + - 'app/models/snippet_repository.rb' + - 'config/initializers/macos.rb' + - 'config/spring.rb' + - 'ee/app/models/ee/container_registry/event.rb' + - 'ee/lib/gitlab/auth/smartcard/certificate.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/kramdown/parser/atlassian_document_format.rb' + - 'lib/prometheus/pid_provider.rb' + - 'qa/qa/specs/runner.rb' + - 'spec/features/projects/jobs_spec.rb' + - 'spec/spec_helper.rb' diff --git a/.rubocop_todo/rails/inquiry.yml b/.rubocop_todo/rails/inquiry.yml new file mode 100644 index 00000000000..3c999dfbc47 --- /dev/null +++ b/.rubocop_todo/rails/inquiry.yml @@ -0,0 +1,4 @@ +--- +Rails/Inquiry: + Exclude: + - 'spec/helpers/labels_helper_spec.rb' diff --git a/.rubocop_todo/rails/render_inline.yml b/.rubocop_todo/rails/render_inline.yml new file mode 100644 index 00000000000..fbebec72cd7 --- /dev/null +++ b/.rubocop_todo/rails/render_inline.yml @@ -0,0 +1,4 @@ +--- +Rails/RenderInline: + Exclude: + - 'ee/app/controllers/sitemap_controller.rb' diff --git a/app/assets/images/learn_gitlab/graduation_hat.svg b/app/assets/images/learn_gitlab/graduation_hat.svg deleted file mode 100644 index 998d8d9b935..00000000000 --- a/app/assets/images/learn_gitlab/graduation_hat.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/assets/javascripts/clusters_list/components/available_agents_dropdown.vue b/app/assets/javascripts/clusters_list/components/available_agents_dropdown.vue index 662cf2a7e36..bde76c46b4b 100644 --- a/app/assets/javascripts/clusters_list/components/available_agents_dropdown.vue +++ b/app/assets/javascripts/clusters_list/components/available_agents_dropdown.vue @@ -3,6 +3,7 @@ import { GlDropdown, GlDropdownItem, GlDropdownDivider, + GlDropdownText, GlSearchBoxByType, GlSprintf, } from '@gitlab/ui'; @@ -15,6 +16,7 @@ export default { GlDropdown, GlDropdownItem, GlDropdownDivider, + GlDropdownText, GlSearchBoxByType, GlSprintf, }, @@ -73,13 +75,24 @@ export default { this.clearSearch(); this.focusSearch(); }, + onKeyEnter() { + if (!this.searchTerm?.length) { + return; + } + this.$refs.dropdown.hide(); + this.selectAgent(this.searchTerm); + }, }, };