kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Remove unnecessary loading of discussions in IssuesController#show

Browse source 
Discussions are now done asynchronously via the `IssuesController#discussions`
endpoint, so this should no longer be needed. This was taking 32% of the load
time for GitLab CE issue 1.

Closes #38034
This commit is contained in:
Stan Hu 2017-09-18 20:43:28 -07:00
parent 1f4911541d
commit 3b9c45a317
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/controllers/projects/issues_controller.rb
View file

@ -71,9 +71,6 @@ class Projects::IssuesController < Projects::ApplicationController
@noteable = @issue
@note = @project.notes.new(noteable: @issue)
@discussions = @issue.discussions
@notes = prepare_notes_for_rendering(@discussions.flat_map(&:notes), @noteable)
respond_to do |format|
format.html
format.json do

5
changelogs/unreleased/sh-stop-loading-issue-discussions.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Remove unnecessary loading of discussions in `IssuesController#show`
merge_request:
author:
type: fixed