diff --git a/.gitlab/ci/memory.gitlab-ci.yml b/.gitlab/ci/memory.gitlab-ci.yml index 520f77cd8ca..c6572d9709c 100644 --- a/.gitlab/ci/memory.gitlab-ci.yml +++ b/.gitlab/ci/memory.gitlab-ci.yml @@ -11,36 +11,9 @@ metrics: "${METRICS_FILE}" expire_in: 31d -# Disabled since it causes intermittent SIGSEGV in CI: -# https://gitlab.com/gitlab-org/gitlab/-/issues/350296 -.memory-static: - extends: .only-code-memory-job-base - stage: test - needs: ["setup-test-env"] - variables: - SETUP_DB: "false" - MEMORY_BUNDLE_MEM_FILE: "tmp/memory_bundle_mem.txt" - MEMORY_BUNDLE_OBJECTS_FILE: "tmp/memory_bundle_objects.txt" - script: - # Uses two different reports from the 'derailed_benchmars' gem. - - # Loads each of gems in the Gemfile and checks how much memory they consume when they are required. - # 'derailed_benchmarks' internally uses 'get_process_mem' - - bundle exec derailed bundle:mem > "${MEMORY_BUNDLE_MEM_FILE}" - - scripts/generate-gems-size-metrics-static "${MEMORY_BUNDLE_MEM_FILE}" >> "${METRICS_FILE}" - - # Outputs detailed information about objects created while gems are loaded. - # 'derailed_benchmarks' internally uses 'memory_profiler' - - bundle exec derailed bundle:objects > "${MEMORY_BUNDLE_OBJECTS_FILE}" - - scripts/generate-gems-memory-metrics-static "${MEMORY_BUNDLE_OBJECTS_FILE}" >> "${METRICS_FILE}" - artifacts: - paths: - - "${METRICS_FILE}" - - "${MEMORY_BUNDLE_MEM_FILE}" - - "${MEMORY_BUNDLE_OBJECTS_FILE}" # Show memory usage caused by invoking require per gem. -# Unlike `memory-static`, it hits the app with one request to ensure that any last minute require-s have been called. +# Hits the app with one request to ensure that any last minute require-s have been called. # The application is booted in `production` environment. # All tests are run without a webserver (directly using Rack::Mock by default). memory-on-boot: diff --git a/.rubocop.yml b/.rubocop.yml index caa9d72ef47..bea2cf66efd 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -97,14 +97,8 @@ RSpec/FilePath: # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: - Max: 28 + Max: 25 AllowSubject: true - Exclude: - - 'spec/migrations/**/*.rb' - - 'spec/lib/gitlab/background_migration/populate_project_snippet_statistics_spec.rb' - - 'spec/lib/gitlab/background_migration/populate_finding_uuid_for_vulnerability_feedback_spec.rb' - - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' - - 'ee/spec/lib/gitlab/background_migration/user_mentions/create_resource_user_mention_spec.rb' Naming/FileName: ExpectMatchingDefinition: true diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml new file mode 100644 index 00000000000..2f6d390bec2 --- /dev/null +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -0,0 +1,11 @@ +--- +RSpec/MultipleMemoizedHelpers: + Exclude: + - spec/lib/gitlab/background_migration/populate_finding_uuid_for_vulnerability_feedback_spec.rb + - spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb + - spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb + - spec/requests/api/ci/runner/jobs_artifacts_spec.rb + - ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb + - ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb + - ee/spec/services/ee/boards/issues/move_service_spec.rb + - ee/spec/services/security/store_report_service_spec.rb diff --git a/.rubocop_todo/style/open_struct_use.yml b/.rubocop_todo/style/open_struct_use.yml index 4f7faa8f484..54ae23d232a 100644 --- a/.rubocop_todo/style/open_struct_use.yml +++ b/.rubocop_todo/style/open_struct_use.yml @@ -17,7 +17,6 @@ Style/OpenStructUse: - spec/factories/go_module_versions.rb - spec/factories/wiki_pages.rb - spec/features/projects/clusters_spec.rb - - spec/finders/template_finder_spec.rb - spec/graphql/mutations/branches/create_spec.rb - spec/graphql/mutations/clusters/agent_tokens/create_spec.rb - spec/graphql/mutations/clusters/agents/create_spec.rb diff --git a/GITLAB_PAGES_VERSION b/GITLAB_PAGES_VERSION index a63cb35e6f0..3f4830156cb 100644 --- a/GITLAB_PAGES_VERSION +++ b/GITLAB_PAGES_VERSION @@ -1 +1 @@ -1.52.0 +1.53.0 diff --git a/app/assets/javascripts/alert_management/components/alert_management_table.vue b/app/assets/javascripts/alert_management/components/alert_management_table.vue index 79a6bac3ba7..84c2b216859 100644 --- a/app/assets/javascripts/alert_management/components/alert_management_table.vue +++ b/app/assets/javascripts/alert_management/components/alert_management_table.vue @@ -15,7 +15,7 @@ import getAlertsQuery from '~/graphql_shared/queries/get_alerts.query.graphql'; import { fetchPolicies } from '~/lib/graphql'; import { convertToSnakeCase } from '~/lib/utils/text_utility'; import { joinPaths, visitUrl } from '~/lib/utils/url_utility'; -import { s__, __ } from '~/locale'; +import { s__, __, n__ } from '~/locale'; import AlertStatus from '~/vue_shared/alert_details/components/alert_status.vue'; import { tdClass, @@ -32,8 +32,11 @@ const TH_TEST_ID = { 'data-testid': 'alert-management-severity-sort' }; const TWELVE_HOURS_IN_MS = 12 * 60 * 60 * 1000; +const MAX_VISIBLE_ASSIGNEES = 4; + export default { trackAlertListViewsOptions, + MAX_VISIBLE_ASSIGNEES, i18n: { noAlertsMsg: s__( 'AlertManagement|No alerts available to display. See %{linkStart}enabling alert management%{linkEnd} for more information on adding alerts to the list.', @@ -258,6 +261,13 @@ export default { this.serverErrorMessage = ''; this.isErrorAlertDismissed = true; }, + assigneesBadgeSrOnlyText(item) { + return n__( + '%d additional assignee', + '%d additional assignees', + item.assignees.nodes.length - MAX_VISIBLE_ASSIGNEES, + ); + }, }, }; @@ -365,10 +375,11 @@ export default {