From 3bded603974e7cd22e90be9911ba0fc08ca26b94 Mon Sep 17 00:00:00 2001 From: Walmyr Lima Date: Thu, 18 Jul 2019 18:50:58 +0200 Subject: [PATCH] Refactor check mentions for xss test The refactor consists in: - Better scopping preconditions and the test definition - Removing a variable that was being used in a single palce, and use the string directly instead. --- .../2_plan/issue/check_mentions_for_xss_spec.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb index 5eceeb9661c..afddbff75bd 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb @@ -3,9 +3,7 @@ module QA context 'Plan' do describe 'check xss occurence in @mentions in issues' do - let(:issue_title) { 'issue title' } - - it 'user mentions a user in comment' do + before do Runtime::Browser.visit(:gitlab, Page::Main::Login) Page::Main::Login.perform(&:sign_in_using_credentials) @@ -25,11 +23,13 @@ module QA end issue = Resource::Issue.fabricate_via_api! do |issue| - issue.title = issue_title + issue.title = 'issue title' issue.project = project end issue.visit! + end + it 'user mentions a user in comment' do Page::Project::Issue::Show.perform do |show_page| show_page.select_all_activities_filter show_page.comment('cc-ing you here @eve')