From 3cbca3776c791819cbcc6890b7c8319f3b40e35f Mon Sep 17 00:00:00 2001
From: Fabio Papa <fabtheman@gmail.com>
Date: Fri, 14 Jun 2019 15:16:55 -0700
Subject: [PATCH] Add failing feature spec detailing a maintainer creating a
 subgroup

- Change the two existing feature examples that create a subgroup to
  elucidate that the owner is creating the subgroup

- Nest two more specs inside the 'subgroup support' context detailing
  what happens when a maintainer attempts to add a subgroup (one with
  subgroup support, and one without)
---
 spec/features/groups/show_spec.rb | 61 ++++++++++++++++++++++++-------
 1 file changed, 48 insertions(+), 13 deletions(-)

diff --git a/spec/features/groups/show_spec.rb b/spec/features/groups/show_spec.rb
index 9671a4d8c49..2654d06cd8c 100644
--- a/spec/features/groups/show_spec.rb
+++ b/spec/features/groups/show_spec.rb
@@ -56,32 +56,67 @@ describe 'Group show page' do
   end
 
   context 'subgroup support' do
-    let(:user) { create(:user) }
+    let(:owner) { create(:user) }
+    let(:maintainer) { create(:user) }
 
     before do
-      group.add_owner(user)
-      sign_in(user)
+      group.add_owner(owner)
+      group.add_maintainer(maintainer)
     end
 
-    context 'when subgroups are supported', :js, :nested_groups do
+    context 'for owners' do
       before do
-        allow(Group).to receive(:supports_nested_objects?) { true }
-        visit path
+        sign_in(owner)
       end
 
-      it 'allows creating subgroups' do
-        expect(page).to have_css("li[data-text='New subgroup']", visible: false)
+      context 'when subgroups are supported', :js, :nested_groups do
+        before do
+          allow(Group).to receive(:supports_nested_objects?) { true }
+          visit path
+        end
+
+        it 'allows creating subgroups' do
+          expect(page).to have_css("li[data-text='New subgroup']", visible: false)
+        end
+      end
+
+      context 'when subgroups are not supported' do
+        before do
+          allow(Group).to receive(:supports_nested_objects?) { false }
+          visit path
+        end
+
+        it 'allows creating subgroups' do
+          expect(page).not_to have_selector("li[data-text='New subgroup']", visible: false)
+        end
       end
     end
 
-    context 'when subgroups are not supported' do
+    context 'for maintainers' do
       before do
-        allow(Group).to receive(:supports_nested_objects?) { false }
-        visit path
+        sign_in(maintainer)
       end
 
-      it 'allows creating subgroups' do
-        expect(page).not_to have_selector("li[data-text='New subgroup']", visible: false)
+      context 'when subgroups are supported', :js, :nested_groups do
+        before do
+          allow(Group).to receive(:supports_nested_objects?) { true }
+          visit path
+        end
+
+        it 'allows creating subgroups' do
+          expect(page).to have_css("li[data-text='New subgroup']", visible: false)
+        end
+      end
+
+      context 'when subgroups are not supported' do
+        before do
+          allow(Group).to receive(:supports_nested_objects?) { false }
+          visit path
+        end
+
+        it 'allows creating subgroups' do
+          expect(page).not_to have_selector("li[data-text='New subgroup']", visible: false)
+        end
       end
     end
   end