Merge branch 'fix-link-to-redmine-issues' into 'master'

Allow Redmine issue references to work as intended

Closes #14527 and #14894 

See merge request !4048
This commit is contained in:
Robert Speicher 2016-05-10 00:29:17 +00:00
commit 3dc64764ad
2 changed files with 4 additions and 0 deletions

View File

@ -40,6 +40,7 @@ v 8.8.0 (unreleased)
v 8.7.4
- Fix always showing build notification message when switching between merge requests
- Fix links on wiki pages for relative url setups. !4026 (Artem Sidorenko)
- Links for Redmine issue references are generated correctly again (Benedikt Huss)
v 8.7.3
- Emails, Gitlab::Email::Message, Gitlab::Diff, and Premailer::Adapter::Nokogiri are now instrumented

View File

@ -10,6 +10,9 @@ module Banzai
end
def self.user_can_see_reference?(user, node, context)
# It is not possible to check access rights for external issue trackers
return true if context[:project].try(:external_issue_tracker)
issue = Issue.find(node.attr('data-issue')) rescue nil
Ability.abilities.allowed?(user, :read_issue, issue)
end