kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Resolve "Branch name status color is not correct anymore"

Browse source
This commit is contained in:
Clement Ho 2018-06-19 21:22:31 +00:00 committed by Tim Zallmann
parent e0da61bca8
commit 3e3f527991
3 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/assets/javascripts/create_merge_request_dropdown.js
View file

@ -366,7 +366,7 @@ export default class CreateMergeRequestDropdown {
removeMessage(target) { removeMessage(target) {
const { input, message } = this.getTargetData(target); const { input, message } = this.getTargetData(target);
const inputClasses = ['gl-field-error-outline', 'gl-field-success-outline']; const inputClasses = ['gl-field-error-outline', 'gl-field-success-outline'];
const messageClasses = ['gl-field-hint', 'gl-field-error-message', 'gl-field-success-message']; const messageClasses = ['text-muted', 'text-danger', 'text-success'];
inputClasses.forEach(cssClass => input.classList.remove(cssClass)); inputClasses.forEach(cssClass => input.classList.remove(cssClass));
messageClasses.forEach(cssClass => message.classList.remove(cssClass)); messageClasses.forEach(cssClass => message.classList.remove(cssClass));
@ -393,7 +393,7 @@ export default class CreateMergeRequestDropdown {
this.removeMessage(target); this.removeMessage(target);
input.classList.add('gl-field-success-outline'); input.classList.add('gl-field-success-outline');
message.classList.add('gl-field-success-message'); message.classList.add('text-success');
message.textContent = sprintf(__('%{text} is available'), { text }); message.textContent = sprintf(__('%{text} is available'), { text });
message.style.display = 'inline-block'; message.style.display = 'inline-block';
} }
@ -403,7 +403,7 @@ export default class CreateMergeRequestDropdown {
const text = target === 'branch' ? __('branch name') : __('source'); const text = target === 'branch' ? __('branch name') : __('source');
this.removeMessage(target); this.removeMessage(target);
message.classList.add('gl-field-hint'); message.classList.add('text-muted');
message.textContent = sprintf(__('Checking %{text} availability…'), { text }); message.textContent = sprintf(__('Checking %{text} availability…'), { text });
message.style.display = 'inline-block'; message.style.display = 'inline-block';
} }
@ -415,7 +415,7 @@ export default class CreateMergeRequestDropdown {
this.removeMessage(target); this.removeMessage(target);
input.classList.add('gl-field-error-outline'); input.classList.add('gl-field-error-outline');
message.classList.add('gl-field-error-message'); message.classList.add('text-danger');
message.textContent = text; message.textContent = text;
message.style.display = 'inline-block'; message.style.display = 'inline-block';
} }

4
app/assets/stylesheets/framework/forms.scss
View file

@ -201,6 +201,10 @@ label {
} }
.gl-show-field-errors { .gl-show-field-errors {
.form-control {
height: 34px;
}
.gl-field-success-outline { .gl-field-success-outline {
border: 1px solid $green-600; border: 1px solid $green-600;

2
app/views/projects/issues/_new_branch.html.haml
View file

@ -40,7 +40,7 @@
%label{ for: 'new-branch-name' } %label{ for: 'new-branch-name' }
= _('Branch name') = _('Branch name')
%input#new-branch-name.js-branch-name.form-control{ type: 'text', placeholder: "#{@issue.to_branch_name}", value: "#{@issue.to_branch_name}" } %input#new-branch-name.js-branch-name.form-control{ type: 'text', placeholder: "#{@issue.to_branch_name}", value: "#{@issue.to_branch_name}" }
%span.js-branch-message.form-text.text-muted %span.js-branch-message.form-text
.form-group .form-group
%label{ for: 'source-name' } %label{ for: 'source-name' }