Adds tests to prevent future errors.
Fix undefined variable in es5
This commit is contained in:
parent
7c9a85e353
commit
401a2ec0b1
|
@ -16,7 +16,7 @@
|
|||
addMarginToBuildColumns() {
|
||||
this.pipelineGraph = document.querySelector('.pipeline-graph');
|
||||
const secondChildBuildNodes = document.querySelector('.pipeline-graph').querySelectorAll('.build:nth-child(2)');
|
||||
for (buildNodeIndex in secondChildBuildNodes) {
|
||||
for (const buildNodeIndex in secondChildBuildNodes) {
|
||||
const buildNode = secondChildBuildNodes[buildNodeIndex];
|
||||
const firstChildBuildNode = buildNode.previousElementSibling;
|
||||
if (!firstChildBuildNode || !firstChildBuildNode.matches('.build')) continue;
|
||||
|
|
|
@ -1,4 +1,4 @@
|
|||
---
|
||||
title: Fix TypeError: Cannot read property 'initTabs' on commit builds tab
|
||||
merge_request:
|
||||
merge_request: 8009
|
||||
author:
|
||||
|
|
|
@ -0,0 +1,15 @@
|
|||
%div.pipeline-visualization.pipeline-graph
|
||||
%ul.stage-column-list
|
||||
%li.stage-column
|
||||
.stage-name
|
||||
%a{:href => "/"}
|
||||
Test
|
||||
.builds-container
|
||||
%ul
|
||||
%li.build
|
||||
.curve
|
||||
.build-content
|
||||
%a
|
||||
%svg
|
||||
.ci-status-text
|
||||
stop_review
|
|
@ -0,0 +1,25 @@
|
|||
//= require pipelines
|
||||
|
||||
(() => {
|
||||
describe('Pipelines', () => {
|
||||
fixture.preload('pipeline_graph');
|
||||
|
||||
beforeEach(() => {
|
||||
fixture.load('pipeline_graph');
|
||||
});
|
||||
|
||||
it('should be defined', () => {
|
||||
expect(window.gl.Pipelines).toBeDefined();
|
||||
});
|
||||
|
||||
it('should create a `Pipelines` instance without options', () => {
|
||||
expect(() => { new window.gl.Pipelines(); }).not.toThrow(); //eslint-disable-line
|
||||
});
|
||||
|
||||
it('should create a `Pipelines` instance with options', () => {
|
||||
const pipelines = new window.gl.Pipelines({ foo: 'bar' });
|
||||
|
||||
expect(pipelines.pipelineGraph).toBeDefined();
|
||||
});
|
||||
});
|
||||
})();
|
Loading…
Reference in New Issue