From 408e010d65e7e2e2b64a694e12d44636d7d81dec Mon Sep 17 00:00:00 2001 From: Douglas Barbosa Alexandre Date: Sat, 20 Feb 2016 10:35:36 -0200 Subject: [PATCH] Rename IssuableBaseService#have_changes? to has_changes? --- app/services/issuable_base_service.rb | 2 +- app/services/issues/update_service.rb | 2 +- app/services/merge_requests/update_service.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/services/issuable_base_service.rb b/app/services/issuable_base_service.rb index fef96639ace..ca87dca4a70 100644 --- a/app/services/issuable_base_service.rb +++ b/app/services/issuable_base_service.rb @@ -71,7 +71,7 @@ class IssuableBaseService < BaseService end end - def have_changes?(issuable, options = {}) + def has_changes?(issuable, options = {}) valid_attrs = [:title, :description, :assignee_id, :milestone_id, :target_branch] attrs_changed = valid_attrs.any? do |attr| diff --git a/app/services/issues/update_service.rb b/app/services/issues/update_service.rb index d2620750305..4d85f6464b1 100644 --- a/app/services/issues/update_service.rb +++ b/app/services/issues/update_service.rb @@ -5,7 +5,7 @@ module Issues end def handle_changes(issue, options = {}) - if have_changes?(issue, options) + if has_changes?(issue, options) task_service.mark_pending_tasks_as_done(issue, current_user) end diff --git a/app/services/merge_requests/update_service.rb b/app/services/merge_requests/update_service.rb index a89daf9821e..b9781864697 100644 --- a/app/services/merge_requests/update_service.rb +++ b/app/services/merge_requests/update_service.rb @@ -15,7 +15,7 @@ module MergeRequests end def handle_changes(merge_request, options = {}) - if have_changes?(merge_request, options) + if has_changes?(merge_request, options) task_service.mark_pending_tasks_as_done(merge_request, current_user) end