Merge branch 'web-ide-default-merge-request' into 'master'

Use Web IDE path for merge request edit buttons

See merge request gitlab-org/gitlab-ce!25595
This commit is contained in:
Nick Thomas 2019-02-28 10:47:10 +00:00
commit 40ec172f75
3 changed files with 10 additions and 4 deletions

View file

@ -37,7 +37,7 @@ module BlobHelper
end
def ide_edit_button(project = @project, ref = @ref, path = @path, options = {})
return unless Feature.enabled?(:web_ide_default)
return if Feature.enabled?(:web_ide_default)
return unless blob = readable_blob(options, path, project, ref)
edit_button_tag(blob,

View file

@ -27,9 +27,13 @@ class DiffFileBaseEntity < Grape::Entity
next unless merge_request.source_project
project_edit_blob_path(merge_request.source_project,
tree_join(merge_request.source_branch, diff_file.new_path),
options)
if Feature.enabled?(:web_ide_default)
ide_edit_path(merge_request.source_project, merge_request.source_branch, diff_file.new_path)
else
project_edit_blob_path(merge_request.source_project,
tree_join(merge_request.source_branch, diff_file.new_path),
options)
end
end
expose :old_path_html do |diff_file|

View file

@ -18,6 +18,8 @@ describe 'a maintainer edits files on a source-branch of an MR from a fork', :js
end
before do
stub_feature_flags(web_ide_default: false)
target_project.add_maintainer(user)
sign_in(user)