diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ec23e500143..23645d61b11 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -278,16 +278,6 @@ Performance/DeletePrefix: - 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb' - 'spec/support/helpers/test_env.rb' -# Offense count: 5 -# Cop supports --auto-correct. -# Configuration parameters: SafeMultiline. -Performance/DeleteSuffix: - Exclude: - - 'app/helpers/submodule_helper.rb' - - 'app/workers/concerns/application_worker.rb' - - 'ee/app/models/geo/upload_registry.rb' - - 'ee/app/workers/geo/file_download_dispatch_worker/attachment_job_finder.rb' - # Offense count: 121 Performance/MethodObjectAsBlock: Enabled: false diff --git a/app/helpers/submodule_helper.rb b/app/helpers/submodule_helper.rb index f1e0be3a622..d3af6a00181 100644 --- a/app/helpers/submodule_helper.rb +++ b/app/helpers/submodule_helper.rb @@ -32,7 +32,7 @@ module SubmoduleHelper namespace.sub!(%r{\A/}, '') project.rstrip! - project.sub!(/\.git\z/, '') + project.delete_suffix!('.git') if self_url?(url, namespace, project) [