kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix enviroments seeding on certain branch names

Browse source 
Bit of a cryptic commit title, but our seeding will try to guard against
branchnames being anything but alphanumerical. These charachters we gsub
away but can't have an empty string as replacement.

This change is less efficient, but given that the number of seeded MRs
per project is very limited, this should be ok.
This commit is contained in:
Zeger-Jan van de Weg 2018-04-09 19:35:11 +02:00
parent 91a3a4b526
commit 43b0dddf38
No known key found for this signature in database
GPG key ID: 65F6A8D64A88ABAC
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
db/fixtures/development/19_environments.rb
View file

@ -28,7 +28,11 @@ class Gitlab::Seeder::Environments
end end
def create_merge_request_review_deployments! def create_merge_request_review_deployments!
@project.merge_requests.sample(4).map do |merge_request| @project
.merge_requests
.select { |mr| mr.source_branch.match(/\p{Alnum}+/) }
.sample(4)
.each do |merge_request|
next unless merge_request.diff_head_sha next unless merge_request.diff_head_sha
create_deployment!( create_deployment!(