From 44275e5066c36da3295f46971385db0e81ca1288 Mon Sep 17 00:00:00 2001
From: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Date: Wed, 22 May 2013 14:06:08 +0300
Subject: [PATCH] Fix huge MR exceptions. Fixed link to diff for it

---
 app/models/merge_request.rb                    | 6 +++---
 app/views/merge_requests/show/_diffs.html.haml | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb
index 89245870ca2..b2ad1b76f1f 100644
--- a/app/models/merge_request.rb
+++ b/app/models/merge_request.rb
@@ -214,9 +214,9 @@ class MergeRequest < ActiveRecord::Base
   end
 
   def dump_diffs(diffs)
-    if broken_diffs?
+    if diffs == broken_diffs
       broken_diffs
-    else
+    elsif diffs.respond_to?(:map)
       diffs.map(&:to_hash)
     end
   end
@@ -224,7 +224,7 @@ class MergeRequest < ActiveRecord::Base
   def load_diffs(raw)
     if raw == broken_diffs
       broken_diffs
-    else
+    elsif raw.respond_to?(:map)
       raw.map { |hash| Gitlab::Git::Diff.new(hash) }
     end
   end
diff --git a/app/views/merge_requests/show/_diffs.html.haml b/app/views/merge_requests/show/_diffs.html.haml
index 0807454c4b0..033d66a4ad4 100644
--- a/app/views/merge_requests/show/_diffs.html.haml
+++ b/app/views/merge_requests/show/_diffs.html.haml
@@ -4,7 +4,7 @@
   %h4.nothing_here_message
     Can't load diff.
     You can
-    = link_to "download it", project_merge_request_path(@project, @merge_request), format: :diff, class: "vlink"
+    = link_to "download it", project_merge_request_path(@project, @merge_request, format: :diff), class: "vlink"
     instead.
 - else
   %h4.nothing_here_message Nothing to merge