diff --git a/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue b/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue index cd2545b48de..d28635db601 100644 --- a/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue +++ b/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue @@ -105,8 +105,8 @@ export default { atVersion: this.designsVersion, }; }, - isDiscussionHighlighted() { - return this.discussion.notes[0].id === this.activeDiscussion.id; + isDiscussionActive() { + return this.discussion.notes.some(({ id }) => id === this.activeDiscussion.id); }, resolveCheckboxText() { return this.discussion.resolved @@ -134,18 +134,6 @@ export default { isFormVisible() { return this.isFormRendered && this.discussionWithOpenForm === this.discussion.id; }, - shouldScrollToDiscussion(activeDiscussion) { - const ALLOWED_ACTIVE_DISCUSSION_SOURCES = [ - ACTIVE_DISCUSSION_SOURCE_TYPES.pin, - ACTIVE_DISCUSSION_SOURCE_TYPES.url, - ]; - const { id: activeDiscussionId, source: activeDiscussionSource } = activeDiscussion; - - return ( - ALLOWED_ACTIVE_DISCUSSION_SOURCES.includes(activeDiscussionSource) && - activeDiscussionId === this.discussion.notes[0].id - ); - }, }, methods: { addDiscussionComment( @@ -199,6 +187,14 @@ export default { this.isResolving = false; }); }, + shouldScrollToDiscussion(activeDiscussion) { + const ALLOWED_ACTIVE_DISCUSSION_SOURCES = [ + ACTIVE_DISCUSSION_SOURCE_TYPES.pin, + ACTIVE_DISCUSSION_SOURCE_TYPES.url, + ]; + const { source } = activeDiscussion; + return ALLOWED_ACTIVE_DISCUSSION_SOURCES.includes(source) && this.isDiscussionActive; + }, }, createNoteMutation, }; @@ -221,7 +217,7 @@ export default { :note="firstNote" :markdown-preview-path="markdownPreviewPath" :is-resolving="isResolving" - :class="{ 'gl-bg-blue-50': isDiscussionHighlighted }" + :class="{ 'gl-bg-blue-50': isDiscussionActive }" @error="$emit('updateNoteError', $event)" >