Merge branch 'fix_broken_diff_discussions' into 'master'

Make diff discussions more reliable

Closes #23646

See merge request !8378

app/models/merge_request.rb

@@ -865,9 +865,11 @@ class MergeRequest < ActiveRecord::Base
       paths: paths
     )
 
-    active_diff_notes.each do |note|
-      service.execute(note)
-      Gitlab::Timeless.timeless(note, &:save)
+    transaction do
+      active_diff_notes.each do |note|
+        service.execute(note)
+        Gitlab::Timeless.timeless(note, &:save)
+      end
     end
   end
 

changelogs/unreleased/fix_broken_diff_discussions.yml

@@ -0,0 +1,4 @@
+---
+title: Make MR-review-discussions more reliable
+merge_request:
+author: