Revert adding favicon to extended statuses. Change extended statues specs to use core status
This commit is contained in:
parent
74f13e0ddf
commit
448c695c2a
|
@ -13,10 +13,6 @@ module Gitlab
|
|||
'icon_status_warning'
|
||||
end
|
||||
|
||||
def favicon
|
||||
'favicon_status_warning'
|
||||
end
|
||||
|
||||
def group
|
||||
'failed_with_warnings'
|
||||
end
|
||||
|
|
|
@ -20,10 +20,6 @@ module Gitlab
|
|||
'icon_status_warning'
|
||||
end
|
||||
|
||||
def favicon
|
||||
'favicon_status_warning'
|
||||
end
|
||||
|
||||
def group
|
||||
'success_with_warnings'
|
||||
end
|
||||
|
|
|
@ -81,7 +81,7 @@ describe Gitlab::Ci::Status::Build::Factory do
|
|||
it 'fabricates status with correct details' do
|
||||
expect(status.text).to eq 'failed'
|
||||
expect(status.icon).to eq 'icon_status_warning'
|
||||
expect(status.favicon).to eq 'favicon_status_warning'
|
||||
expect(status.favicon).to eq 'favicon_status_failed'
|
||||
expect(status.label).to eq 'failed (allowed to fail)'
|
||||
expect(status).to have_details
|
||||
expect(status).to have_action
|
||||
|
|
|
@ -22,12 +22,6 @@ describe Gitlab::Ci::Status::Build::FailedAllowed do
|
|||
end
|
||||
end
|
||||
|
||||
describe '#favicon' do
|
||||
it 'returns a warning favicon' do
|
||||
expect(subject.favicon).to eq 'favicon_status_warning'
|
||||
end
|
||||
end
|
||||
|
||||
describe '#label' do
|
||||
it 'returns information about failed but allowed to fail status' do
|
||||
expect(subject.label).to eq 'failed (allowed to fail)'
|
||||
|
|
|
@ -17,10 +17,6 @@ describe Gitlab::Ci::Status::SuccessWarning do
|
|||
it { expect(subject.icon).to eq 'icon_status_warning' }
|
||||
end
|
||||
|
||||
describe '#favicon' do
|
||||
it { expect(subject.favicon).to eq 'favicon_status_warning' }
|
||||
end
|
||||
|
||||
describe '#group' do
|
||||
it { expect(subject.group).to eq 'success_with_warnings' }
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue