Find label in issues_finder

This commit is contained in:
Tap 2016-02-19 13:27:41 +08:00
parent a9907de49a
commit 44a9e26049
3 changed files with 20 additions and 4 deletions

View file

@ -6,7 +6,7 @@ module IssuesAction
@issues = @issues.page(params[:page]).per(ApplicationController::PER_PAGE) @issues = @issues.page(params[:page]).per(ApplicationController::PER_PAGE)
@issues = @issues.preload(:author, :project) @issues = @issues.preload(:author, :project)
@label = Label.where(project: @projects).find_by(title: params[:label_name]) @label = @issuable_finder.labels.first
respond_to do |format| respond_to do |format|
format.html format.html

View file

@ -6,6 +6,6 @@ module MergeRequestsAction
@merge_requests = @merge_requests.page(params[:page]).per(ApplicationController::PER_PAGE) @merge_requests = @merge_requests.page(params[:page]).per(ApplicationController::PER_PAGE)
@merge_requests = @merge_requests.preload(:author, :target_project) @merge_requests = @merge_requests.preload(:author, :target_project)
@label = Label.where(project: @projects).find_by(title: params[:label_name]) @label = @issuable_finder.labels.first
end end
end end

View file

@ -119,6 +119,20 @@ class IssuableFinder
labels? && params[:label_name] == Label::None.title labels? && params[:label_name] == Label::None.title
end end
def labels
return @labels if defined?(@labels)
if labels? && !filter_by_no_label?
@labels = Label.where(title: label_names)
if projects
@labels = labels.where(project: projects)
end
else
@labels = Label.none
end
end
def assignee? def assignee?
params[:assignee_id].present? params[:assignee_id].present?
end end
@ -253,8 +267,6 @@ class IssuableFinder
joins("LEFT OUTER JOIN label_links ON label_links.target_type = '#{klass.name}' AND label_links.target_id = #{klass.table_name}.id"). joins("LEFT OUTER JOIN label_links ON label_links.target_type = '#{klass.name}' AND label_links.target_id = #{klass.table_name}.id").
where(label_links: { id: nil }) where(label_links: { id: nil })
else else
label_names = params[:label_name].split(",")
items = items.joins(:labels).where(labels: { title: label_names }) items = items.joins(:labels).where(labels: { title: label_names })
if projects if projects
@ -266,6 +278,10 @@ class IssuableFinder
items items
end end
def label_names
params[:label_name].split(',')
end
def current_user_related? def current_user_related?
params[:scope] == 'created-by-me' || params[:scope] == 'authored' || params[:scope] == 'assigned-to-me' params[:scope] == 'created-by-me' || params[:scope] == 'authored' || params[:scope] == 'assigned-to-me'
end end