Improve readability of 'rake cache:clear' code

This commit is contained in:
Jacob Vosmaer 2016-02-19 14:18:57 +01:00
parent c21c8825d8
commit 44e4f07037

View file

@ -1,22 +1,21 @@
namespace :cache do namespace :cache do
CLEAR_BATCH_SIZE = 1000 CLEAR_BATCH_SIZE = 1000 # The more the faster, but having too many can crash Ruby
REDIS_SCAN_START_STOP = '0' # Magic value, see http://redis.io/commands/scan REDIS_SCAN_START_STOP = '0' # Magic value, see http://redis.io/commands/scan
desc "GitLab | Clear redis cache" desc "GitLab | Clear redis cache"
task :clear => :environment do task :clear => :environment do
redis_store = Rails.cache.instance_variable_get(:@data) redis_store = Rails.cache.instance_variable_get(:@data)
cursor = [REDIS_SCAN_START_STOP, []] cursor = REDIS_SCAN_START_STOP
loop do loop do
cursor = redis_store.scan( cursor, keys = redis_store.scan(
cursor.first, cursor,
match: "#{Gitlab::REDIS_CACHE_NAMESPACE}*", match: "#{Gitlab::REDIS_CACHE_NAMESPACE}*",
count: CLEAR_BATCH_SIZE count: CLEAR_BATCH_SIZE
) )
keys = cursor.last
redis_store.del(*keys) if keys.any? redis_store.del(*keys) if keys.any?
break if cursor.first == REDIS_SCAN_START_STOP break if cursor == REDIS_SCAN_START_STOP
end end
end end
end end