From 45631562565760add7a7c52a6137e891f3a0c8f4 Mon Sep 17 00:00:00 2001 From: Filipa Lacerda Date: Thu, 23 Nov 2017 12:04:03 +0000 Subject: [PATCH] Improve environments performance --- .../environments/components/container.vue | 71 +++++ .../environments/components/empty_state.vue | 42 +++ .../environments/components/environment.vue | 270 ------------------ .../components/environment_external_url.vue | 3 +- .../components/environment_item.vue | 8 +- .../components/environment_monitoring.vue | 3 +- .../components/environment_rollback.vue | 4 +- .../components/environments_app.vue | 128 +++++++++ .../components/environments_table.vue | 16 +- .../environments/environments_bundle.js | 35 ++- .../folder/environments_folder_bundle.js | 31 +- .../folder/environments_folder_view.vue | 253 +++------------- .../environments/mixins/environments_mixin.js | 167 ++++++++++- .../environments/stores/environments_store.js | 7 +- .../javascripts/lib/utils/common_utils.js | 40 --- .../pipelines/components/pipelines.vue | 31 +- .../components/navigation_tabs.vue | 29 +- .../mixins/ci_pagination_api_mixin.js | 42 +++ .../projects/environments_controller.rb | 1 + .../projects/environments/folder.html.haml | 4 +- .../projects/environments/index.html.haml | 4 +- .../environments/environments_spec.rb | 35 ++- .../environments/emtpy_state_spec.js | 57 ++++ .../environments/environment_table_spec.js | 31 +- ...nment_spec.js => environments_app_spec.js} | 134 +++++---- .../folder/environments_folder_view_spec.js | 161 ++++++----- .../fixtures/environments/element.html.haml | 1 - .../environments/environments.html.haml | 9 - .../environments_folder_view.html.haml | 7 - .../lib/utils/common_utils_spec.js | 41 --- spec/javascripts/pipelines/pipelines_spec.js | 64 +++-- .../components}/navigation_tabs_spec.js | 14 +- 32 files changed, 936 insertions(+), 807 deletions(-) create mode 100644 app/assets/javascripts/environments/components/container.vue create mode 100644 app/assets/javascripts/environments/components/empty_state.vue delete mode 100644 app/assets/javascripts/environments/components/environment.vue create mode 100644 app/assets/javascripts/environments/components/environments_app.vue rename app/assets/javascripts/{pipelines => vue_shared}/components/navigation_tabs.vue (56%) create mode 100644 app/assets/javascripts/vue_shared/mixins/ci_pagination_api_mixin.js create mode 100644 spec/javascripts/environments/emtpy_state_spec.js rename spec/javascripts/environments/{environment_spec.js => environments_app_spec.js} (70%) delete mode 100644 spec/javascripts/fixtures/environments/element.html.haml delete mode 100644 spec/javascripts/fixtures/environments/environments.html.haml delete mode 100644 spec/javascripts/fixtures/environments/environments_folder_view.html.haml rename spec/javascripts/{pipelines => vue_shared/components}/navigation_tabs_spec.js (70%) diff --git a/app/assets/javascripts/environments/components/container.vue b/app/assets/javascripts/environments/components/container.vue new file mode 100644 index 00000000000..3236077c3cf --- /dev/null +++ b/app/assets/javascripts/environments/components/container.vue @@ -0,0 +1,71 @@ + + + diff --git a/app/assets/javascripts/environments/components/empty_state.vue b/app/assets/javascripts/environments/components/empty_state.vue new file mode 100644 index 00000000000..2646f08c8e6 --- /dev/null +++ b/app/assets/javascripts/environments/components/empty_state.vue @@ -0,0 +1,42 @@ + + diff --git a/app/assets/javascripts/environments/components/environment.vue b/app/assets/javascripts/environments/components/environment.vue deleted file mode 100644 index ffb7757bed8..00000000000 --- a/app/assets/javascripts/environments/components/environment.vue +++ /dev/null @@ -1,270 +0,0 @@ - - diff --git a/app/assets/javascripts/environments/components/environment_external_url.vue b/app/assets/javascripts/environments/components/environment_external_url.vue index 6b749814ea4..520c3ac8ace 100644 --- a/app/assets/javascripts/environments/components/environment_external_url.vue +++ b/app/assets/javascripts/environments/components/environment_external_url.vue @@ -1,5 +1,6 @@ + diff --git a/app/assets/javascripts/environments/components/environments_table.vue b/app/assets/javascripts/environments/components/environments_table.vue index 175cc8f1f72..c04da4b81b7 100644 --- a/app/assets/javascripts/environments/components/environments_table.vue +++ b/app/assets/javascripts/environments/components/environments_table.vue @@ -2,12 +2,12 @@ /** * Render environments table. */ -import EnvironmentTableRowComponent from './environment_item.vue'; +import environmentItem from './environment_item.vue'; import loadingIcon from '../../vue_shared/components/loading_icon.vue'; export default { components: { - 'environment-item': EnvironmentTableRowComponent, + environmentItem, loadingIcon, }, @@ -42,19 +42,19 @@ export default {
- Environment + {{s__("Environments|Environment")}}
- Deployment + {{s__("Environments|Deployment")}}
- Job + {{s__("Environments|Job")}}
- Commit + {{s__("Environments|Commit")}}
- Updated + {{s__("Environments|Updated")}}