WebIDE: Make Ctrl+Enter automatically commit when commit textarea is focused

This commit is contained in:
Thomas Pathier 2018-11-26 08:40:18 +00:00 committed by Phil Hughes
parent 10e4c87317
commit 4567713985
5 changed files with 20 additions and 0 deletions

View File

@ -126,6 +126,7 @@ export default {
:text="commitMessage"
:placeholder="preBuiltCommitMessage"
@input="updateCommitMessage"
@submit="commitChanges"
/>
<div class="clearfix prepend-top-15">
<actions />

View File

@ -49,6 +49,10 @@ export default {
onInput(e) {
this.$emit('input', e.target.value);
},
onCtrlEnter() {
if (!this.isFocused) return;
this.$emit('submit');
},
updateIsFocused(isFocused) {
this.isFocused = isFocused;
},
@ -109,6 +113,8 @@ export default {
@input="onInput"
@focus="updateIsFocused(true);"
@blur="updateIsFocused(false);"
@keydown.ctrl.enter="onCtrlEnter"
@keydown.meta.enter="onCtrlEnter"
>
</textarea>
</div>

View File

@ -249,6 +249,13 @@
- else
%kbd ctrl p
%td Go to file
%tr
%td.shortcut
- if browser.platform.mac?
%kbd &#8984; enter
- else
%kbd ctrl enter
%td Commit (when editing commit message)
.col-lg-4
%table.shortcut-mappings
%tbody.hidden-shortcut{ style: 'display:none' }

View File

@ -0,0 +1,5 @@
---
title: "WebIDE: Pressing Ctrl-Enter while typing on the commit message now performs the commit action"
merge_request: 23049
author: Thomas Pathier
type: added

View File

@ -94,3 +94,4 @@ You can see GitLab's keyboard shortcuts by using 'shift + ?'
| Keyboard Shortcut | Description |
| ----------------- | ----------- |
| <kbd>Cmd</kbd>/<kbd>Ctrl</kbd> + <kbd>p</kbd> | Go to file |
| <kbd>Cmd</kbd>/<kbd>Ctrl</kbd> + <kbd>Enter</kbd> | Commit (when editing the commit message) |