kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

remove unnecessary Commit.new

Browse source
This commit is contained in:
Dmitriy Zaporozhets 2013-03-31 23:58:17 +03:00
parent bbfbff3add
commit 458631c5ba
3 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/contexts/commit_load_context.rb
View file

@ -12,7 +12,6 @@ class CommitLoadContext < BaseContext
commit = project.repository.commit(params[:id]) commit = project.repository.commit(params[:id])
if commit if commit
commit = Commit.new(commit)
line_notes = project.notes.for_commit_id(commit.id).inline line_notes = project.notes.for_commit_id(commit.id).inline
result[:commit] = commit result[:commit] = commit

4
app/helpers/commits_helper.rb
View file

@ -109,9 +109,7 @@ module CommitsHelper
end end
def commit_to_html commit def commit_to_html commit
if commit.model escape_javascript(render 'commits/commit', commit: commit)
escape_javascript(render 'commits/commit', commit: commit)
end
end end
def diff_line_content(line) def diff_line_content(line)

2
app/models/note.rb
View file

@ -130,7 +130,7 @@ class Note < ActiveRecord::Base
# override to return commits, which are not active record # override to return commits, which are not active record
def noteable def noteable
if for_commit? if for_commit?
Commit.new(project.repository.commit(commit_id)) project.repository.commit(commit_id)
else else
super super
end end