From 46287f3638f2e285ccc46fc50bd9b7b0dc9d9bc3 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Fri, 17 Mar 2017 17:54:56 +0800 Subject: [PATCH] Make sure alias email would never match: Hopefully this could fix: https://gitlab.com/gitlab-org/gitlab-ce/builds/12431186 To make sure that the email would never contain "joh" otherwise it would match to this `another_user`. --- spec/models/user_spec.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index 9da4140f3ce..90378179e32 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -699,7 +699,9 @@ describe User, models: true do let!(:user) { create(:user, name: 'John Doe', username: 'john.doe', email: 'john.doe@example.com' ) } let!(:another_user) { create(:user, name: 'Albert Smith', username: 'albert.smith', email: 'albert.smith@example.com' ) } - let!(:email) { create(:email, user: another_user) } + let!(:email) do + create(:email, user: another_user, email: 'alias@example.com') + end it 'returns users with a matching name' do expect(search_with_secondary_emails(user.name)).to eq([user])