From 4648d0016f67c9b780e3fff475e458fc28825daf Mon Sep 17 00:00:00 2001 From: Alexis Reigel Date: Mon, 26 Jun 2017 14:41:17 +0200 Subject: [PATCH] popover trigger needs to be defined in js init According to https://github.com/twbs/bootstrap/issues/10547 it's not possible to have the trigger defined on the delegated element, i.e. not defined as a data attribute. --- app/assets/javascripts/main.js | 3 ++- app/helpers/commits_helper.rb | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/main.js b/app/assets/javascripts/main.js index ecf7a677c99..d039ca9e47c 100644 --- a/app/assets/javascripts/main.js +++ b/app/assets/javascripts/main.js @@ -251,7 +251,8 @@ $(function () { }); // Initialize popovers $body.popover({ - selector: '[data-toggle="popover"]' + selector: '[data-toggle="popover"]', + trigger: 'focus' }); $('.trigger-submit').on('change', function () { return $(this).parents('form').submit(); diff --git a/app/helpers/commits_helper.rb b/app/helpers/commits_helper.rb index e31baa52e99..42e9379d1f4 100644 --- a/app/helpers/commits_helper.rb +++ b/app/helpers/commits_helper.rb @@ -283,7 +283,6 @@ module CommitsHelper toggle: 'popover', html: 'true', placement: 'auto bottom', - trigger: 'focus', title: title, content: content }