kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

fixes job dropdown action button error

Browse source
This commit is contained in:
Nur Rony 2017-02-13 16:10:39 +06:00 committed by Filipa Lacerda
parent f106ad5135
commit 4792eb7ab4
2 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
app/assets/javascripts/vue_pipelines_index/stage.js.es6
View file

@ -37,15 +37,19 @@
return flash;
});
},
/**
* When the user right clicks or cmd/ctrl + click in the job name or action icon,
* the dropdown should not be closed and the link should open in another tab.
* If the target is a svg we stop propagation in order to prevent
* the default behavior of the dropdown.
*/
keepGraph(e) {
const { target } = e;
const svgClassName = target.getAttribute('class');
const svgParentClassName = target.parentElement && target.parentElement.getAttribute('class');
if (target.className.indexOf('js-ci-action-icon') >= 0) return null;
if (
target.parentElement &&
(target.parentElement.className.indexOf('js-ci-action-icon') >= 0)
) return null;
if (svgClassName && svgClassName.indexOf('js-ci-action-icon') >= 0) return null;
if (svgParentClassName && svgParentClassName.indexOf('js-ci-action-icon') >= 0) return null;
return e.stopPropagation();
},

4
changelogs/unreleased/27530-fix-job-dropdown-pipeline-console-error.yml Normal file
View file

@ -0,0 +1,4 @@
---
title: Fixes job dropdown action throws error in js console
merge_request: 9182
author: